Show the current release version on the index page #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already log this version to the console and include it in a comment at the bottom of each page. Add the release version above the title on the index page. This fixes #121.
|
cc. @timpaul, @edwardhorsford, @joelanman. |
|
thanks Gemma! I think it looks/reads a bit better underneath - what do you reckon?
|
|
also reminds me it'd be good to look at #163 |
|
I think I prefer it above. |
|
a screen reader would read out 'v3.0.0 The GOV.UK prototype kit', which is a bit odd |
|
I think that's a general issue we have with this design - the accessibility team is about to work on improving the markup for these 'subheads' or whatever we're calling them so they read better for screen readers. |
|
This is a version number not a section or category subheading, so below makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already log this version to the console when the app is run and it is included in a comment
at the bottom of each page.
Add the release version above the title on the index page.
This will also make it easy to see that the kit when deployed to Heroku is up to date.
This fixes #121.