Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #4

Merged
merged 40 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #4

merged 40 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 15, 2021 •
edited
Loading

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the completions_plugin_teardown branch from f34653a to d8710d4 Compare July 15, 2021 18:05
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch 2 times, most recently from b8f03f8 to 9602fd4 Compare July 15, 2021 19:28
@andfoy andfoy mentioned this pull request Jul 15, 2021
Merged
@andfoy andfoy changed the title [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
@andfoy andfoy force-pushed the completions_plugin_teardown branch from 141831b to de8c2d9 Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch 2 times, most recently from 5b8b359 to e842e4d Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch 4 times, most recently from 30c2bbe to c49b4ba Compare August 31, 2021 21:19
@andfoy andfoy force-pushed the completions_plugin_teardown branch 2 times, most recently from be51d21 to e749d26 Compare August 31, 2021 22:35
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch 3 times, most recently from 97b1747 to cf9f1b7 Compare August 31, 2021 22:49
@andfoy andfoy force-pushed the completions_plugin_teardown branch from 38266d5 to 1b2e3f6 Compare August 31, 2021 22:54
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch from cf9f1b7 to 07d7d96 Compare August 31, 2021 22:54
andfoy added 27 commits October 6, 2021 14:21
@andfoy
Address review comments
60808bd
@andfoy
Migrate projects to use the new teardown mechanism
fe88c88
@andfoy
Update calls to remove_item_from_application_menu
6bd0b9d
@andfoy
Address review comments
72e60d1
@andfoy
Address further review comments
86045af
@andfoy
Minor error correction
7370c40
@andfoy
Restore sig_stop_completions connection
a22feb1
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
158338a
@andfoy
Remove hard reference to editor in pylint
66e1ebe
@andfoy
Update calls to remove_item_from_application_menu
17167be
@andfoy
Address review comments
2e4ddff
@andfoy
Final review comments
eed84fd
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
aa426e5
@andfoy
Update calls to remove_item_from_application_menu
c29806d
@andfoy
Address review comments
4fd7920
@andfoy
Add proper signature to statusbar on_close method
aad80bd
@andfoy
Address review comments
b5f5e5e
@andfoy
Migrate variable explorer and working directory to use the new teardo…
d07cdf4 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
86fd890
@andfoy
Apply review comments
ee60ca0
@andfoy
Remove duplicate on__close
d31892c
@andfoy
Add preference page to enable and disable plugins
7641139
@andfoy
Restart Spyder after a plugin is enabled/disabled
b36c492
@andfoy
Disable also Spyder 4 plugins
7b8f52f
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
522d158
@andfoy
Address review comments
2d8c268
@andfoy
Always add external plugin metadata
9f84e98
@andfoy andfoy merged commit 877fbf3 into completions_plugin_teardown Oct 6, 2021
@andfoy andfoy deleted the console_explorer_find_plugins_teardown branch October 6, 2021 19:22
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12