-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add plugin teardown operations to the plugin registry #16012
Conversation
Hello @andfoy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-10-06 22:37:21 UTC |
3f14f7b
to
5fff317
Compare
f147a4f
to
9a844b4
Compare
53c3c26
to
4c91825
Compare
24407ef
to
aaefe8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @andfoy, one last, tiny review, then this should be (at last!) ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @andfoy for your hard work and patience with this one. This is a great improvement!
Description of Changes
This PR adds plugin teardown capabilities to the already existing plugin registration mechanism. By using the teardown functions, Spyder will be able to disable and enable plugins without restarting.
Issue(s) Resolved
Fixes #15594
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @andfoy
Stacked PR Chain: [spy-plugin-registry-teardown]