Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-list): properly render leading and trailing icons on list items #19201

Merged
merged 8 commits into from
May 13, 2020

Conversation

mmalerba
Copy link
Contributor

blocked on #19168

Note: I made some changes to the original list demo in this PR:

  1. mat-list-icon and mat-list-avatar were pretty much 2 ways to do the same thing in the old version. In the new version, I'm positioning mat-list-avatar as the bigger leading icon style, and mat-list-icon as the smaller leading icon style (MDC supports both, and they call the larger one an "avatar", so this actually aligns well). I've changed the demo for the old version to show using mat-list-icon in a similar way.
  2. One of the nav list demos was showing a not accessible pattern wit a trailing action button. I updated it to be a standard mat list instead of a nav list.

@mmalerba mmalerba added blocked This issue is blocked by some external factor, such as a prerequisite PR merge safe target: patch This PR is targeted for the next patch release labels Apr 28, 2020
@mmalerba mmalerba requested a review from jelbourn April 28, 2020 22:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2020
@mmalerba mmalerba force-pushed the mdc-list-2 branch 3 times, most recently from d2fc2a3 to 1c60bbb Compare May 8, 2020 21:38
@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label May 8, 2020
@mmalerba mmalerba requested a review from a team as a code owner May 8, 2020 21:51
@mmalerba
Copy link
Contributor Author

mmalerba commented May 8, 2020

This is rebased and ready for review

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 12, 2020
@mmalerba mmalerba merged commit e408228 into angular:master May 13, 2020
@mmalerba mmalerba deleted the mdc-list-2 branch May 13, 2020 02:11
mmalerba added a commit that referenced this pull request May 15, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants