-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cdk/testing): Get webdriver test suite running with dummy tests #22344
test(cdk/testing): Get webdriver test suite running with dummy tests #22344
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
ready for review |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
…22344) Co-authored-by: Paul Gschwendtner <[email protected]>
* feat(cdk/testing): create a webdriver harness environment (#22321) * test(cdk/testing): Get webdriver test suite running with dummy tests (#22344) Co-authored-by: Paul Gschwendtner <[email protected]> * test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367) * test(cdk/testing): port the protractor tests to the webdriver env (#22375) * test(cdk/testing): enable webdriver tests on CI (#22379) Co-authored-by: Paul Gschwendtner <[email protected]> * fixup! test(cdk/testing): enable webdriver tests on CI (#22379) Co-authored-by: Paul Gschwendtner <[email protected]>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
HUGE thanks to @kyliau for the example I used as a reference (https://github.com/kyliau/angular-wait/blob/main/test/test.ts) and @devversion for getting it to actually run in Bazel.
Me trying to set up WebDriver tests in Bazel:
