Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cdk/testing): enable webdriver tests on CI #22379

Merged
merged 8 commits into from
Apr 2, 2021
Merged

test(cdk/testing): enable webdriver tests on CI #22379

merged 8 commits into from
Apr 2, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 31, 2021 •
edited
Loading

Fixes webdriver tests & test setups so they'll run on CI.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 31, 2021
@mmalerba mmalerba force-pushed the webdriver branch 3 times, most recently from 216aef9 to 43bb4e3 Compare April 1, 2021 07:08
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 1, 2021
@mmalerba mmalerba changed the title feat(cdk/testing): create a webdriver harness environment (#22321) test(cdk/testing): enable webdriver tests on CI Apr 1, 2021
@mmalerba mmalerba force-pushed the webdriver branch 9 times, most recently from 0fa8ec6 to ce953b4 Compare April 1, 2021 23:21
@google-cla
Copy link

google-cla bot commented Apr 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@angular angular deleted a comment from google-cla bot Apr 1, 2021
@google-cla
Copy link

google-cla bot commented Apr 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Apr 2, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches) and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 2, 2021
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 2, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 2, 2021
@mmalerba
test(cdk/testing): remove webdriver firefox tests
9d7595a 
We don't test our protractor e2e tests against firefox either. There
seem to be some issues with WebDriver Actions & firefox which affect
both our Protractor and WebDriver tests.
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 2, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 2, 2021
@mmalerba mmalerba marked this pull request as ready for review April 2, 2021 03:16
@mmalerba mmalerba requested review from devversion and a team as code owners April 2, 2021 03:16
wagnermaciel
wagnermaciel approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jelbourn
jelbourn approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels Apr 2, 2021
@mmalerba mmalerba merged commit 0860a32 into angular:webdriver-harness-environment Apr 2, 2021
@mmalerba mmalerba deleted the webdriver branch April 2, 2021 18:45
mmalerba added a commit that referenced this pull request Apr 6, 2021
@mmalerba
fixup! test(cdk/testing): enable webdriver tests on CI (#22379)
57a3db8
mmalerba added a commit that referenced this pull request Apr 8, 2021
@mmalerba @devversion
feat(cdk/testing): create a webdriver harness environment (#22410)
91969f3 
* feat(cdk/testing): create a webdriver harness environment (#22321)

* test(cdk/testing): Get webdriver test suite running with dummy tests (#22344)

Co-authored-by: Paul Gschwendtner <[email protected]>

* test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367)

* test(cdk/testing): port the protractor tests to the webdriver env (#22375)

* test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>

* fixup! test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @wagnermaciel @devversion