Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cdk/testing): start the e2e-app and run webdriver tests in bazel #22367

Merged
merged 1 commit into from
Mar 30, 2021
Merged

test(cdk/testing): start the e2e-app and run webdriver tests in bazel #22367

merged 1 commit into from
Mar 30, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 30, 2021 •
edited
Loading

This solution is temporary and linux-only. We should eventually replace
it with a more robust solution

@google-cla
Copy link

google-cla bot commented Mar 30, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 30, 2021
@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 30, 2021
@mmalerba mmalerba changed the title WIP: start the e2e-app and run webdriver tests in bazel test(cdk/testing): start the e2e-app and run webdriver tests in bazel Mar 30, 2021
@mmalerba mmalerba marked this pull request as ready for review March 30, 2021 17:12
@mmalerba mmalerba requested a review from devversion as a code owner March 30, 2021 17:12
@mmalerba
Copy link
Contributor Author

Ready for review

@mmalerba mmalerba added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 30, 2021
devversion
devversion approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Looks like it's broken in the CircleCI/RBE containers too, but as you said it's temporary.

@mmalerba
test(cdk/testing): start the e2e-app and run webdriver tests in bazel
c1fbb2d 
This solution is temporary and linux-only. We should eventually replace
it with a more robust solution
@mmalerba mmalerba merged commit 6e3566e into angular:webdriver-harness-environment Mar 30, 2021
@mmalerba mmalerba deleted the webdriver-2 branch March 30, 2021 19:26
mmalerba added a commit that referenced this pull request Mar 31, 2021
@mmalerba
test(cdk/testing): start the e2e-app and run webdriver tests in bazel (…
b403d0e 
…#22367)
mmalerba added a commit that referenced this pull request Apr 8, 2021
@mmalerba @devversion
feat(cdk/testing): create a webdriver harness environment (#22410)
91969f3 
* feat(cdk/testing): create a webdriver harness environment (#22321)

* test(cdk/testing): Get webdriver test suite running with dummy tests (#22344)

Co-authored-by: Paul Gschwendtner <[email protected]>

* test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367)

* test(cdk/testing): port the protractor tests to the webdriver env (#22375)

* test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>

* fixup! test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @devversion