Ensure that we can still render log templates even when a DagRun hasn't yet started. #46720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
approved these changes
Feb 13, 2025
ashb
added a commit
that referenced
this pull request
Feb 13, 2025
This PR itself doesn't contain any tests, those happen in #46720 (due to the change in how we create test DagRuns via the fixture), but that is failing until we make this change and I don't want the provider change to be in the same PR as the core log rendering one.
ashb
force-pushed
the
new-ui-unstarted-tilog-exception
branch
from
046b20d to
d6e2fd8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ashb
added a commit
that referenced
this pull request
Feb 13, 2025
This PR itself doesn't contain any tests, those happen in #46720 (due to the change in how we create test DagRuns via the fixture), but that is failing until we make this change and I don't want the provider change to be in the same PR as the core log rendering one.
ashb
force-pushed
the
new-ui-unstarted-tilog-exception
branch
from
23a0f69 to
a6e3d68
Compare
…'t yet started. It doesn't really make logical sense to look at logs in this case, but creating the log filename in the API server shouldn't fail for this. The problem was that the TaskSDK's DagRun model validated that `start_date` was non-null, which makes sense for it (as a TI should never make it to a worker unless it's started!) but didn't make sense for the context we were using it in. The fix here is to not build a full context object but just the minimal dictionary of items we explicitly need/allow in log templates.
ashb
force-pushed
the
new-ui-unstarted-tilog-exception
branch
from
a6e3d68 to
af68918
Compare
hussein-awala
approved these changes
Feb 13, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…#46722) This PR itself doesn't contain any tests, those happen in apache#46720 (due to the change in how we create test DagRuns via the fixture), but that is failing until we make this change and I don't want the provider change to be in the same PR as the core log rendering one.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…'t yet started. (apache#46720) It doesn't really make logical sense to look at logs in this case, but creating the log filename in the API server shouldn't fail for this. The problem was that the TaskSDK's DagRun model validated that `start_date` was non-null, which makes sense for it (as a TI should never make it to a worker unless it's started!) but didn't make sense for the context we were using it in. The fix here is to not build a full context object but just the minimal dictionary of items we explicitly need/allow in log templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really make logical sense to look at logs in this case, but
creating the log filename in the API server shouldn't fail for this.
The problem was that the TaskSDK's DagRun model validated that
start_datewas non-null, which makes sense for it (as a TI should never make it to a
worker unless it's started!) but didn't make sense for the context we were
using it in. The fix here is to not build a full context object but just the
minimal dictionary of items we explicitly need/allow in log templates.