Update OpenLineage emmiter to cope with nullable logical_date #46722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR itself doesn't contain any tests, those happen in #46720 (due to the change in how we create test DagRuns via the fixture), but that is failing until we make this change and I don't want the provider change to be in the same PR as the core log rendering one.
mobuchowski
approved these changes
Feb 13, 2025
amoghrajesh
approved these changes
Feb 13, 2025
|
Only failures are related to #46608 |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…#46722) This PR itself doesn't contain any tests, those happen in apache#46720 (due to the change in how we create test DagRuns via the fixture), but that is failing until we make this change and I don't want the provider change to be in the same PR as the core log rendering one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR itself doesn't contain any tests, those happen in #46720 (due to the
change in how we create test DagRuns via the fixture), but that is failing
until we make this change and I don't want the provider change to be in the
same PR as the core log rendering one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.