[SPARK-27004][core] Remove stale HTTP auth code. #24033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is from the era when Spark used an HTTP server to distribute dependencies, which is long gone. Nowadays it only causes problems when someone is using dependencies from an HTTP server with Spark auth on.
|
Test build #103236 has finished for PR 24033 at commit
|
felixcheung
approved these changes
Mar 9, 2019
|
There's nothing to document. The original feature doesn't exist, and all this code does now is break things if someone is trying to download from https. |
gaborgsomogyi
approved these changes
Mar 11, 2019
|
Merging to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 29, 2020
### What changes were proposed in this pull request? This is kind of a followup of #24033. The first and last usage of that argument `SecurityManager` was removed in #24033. After that, we don't need to pass `SecurityManager` anymore in `Utils.fetchFile` and related code paths. This PR proposes to remove it out. ### Why are the changes needed? For better readability of codes. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually complied. GitHub Actions and Jenkins build should test it out as well. Closes #30945 from HyukjinKwon/SPARK-33925. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 25, 2021
### What changes were proposed in this pull request? This is kind of a followup of #24033 and #30945. Many of references in `SecurityManager` were introduced from SPARK-1189, and related usages were removed later from #24033 and #30945. This PR proposes to remove them out. ### Why are the changes needed? For better readability of codes. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually complied. GitHub Actions and Jenkins build should test it out as well. Closes #31636 from HyukjinKwon/SPARK-34520. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is from the era when Spark used an HTTP server to distribute
dependencies, which is long gone. Nowadays it only causes problems when
someone is using dependencies from an HTTP server with Spark auth on.