[SPARK-34520][CORE] Remove unused SecurityManager references #31636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
requested review from
srowen and
dongjoon-hyun
and removed request for
srowen
HyukjinKwon
commented
Feb 24, 2021
core/src/main/scala/org/apache/spark/metrics/sink/PrometheusServlet.scala
Outdated
Show resolved
Hide resolved
srowen
approved these changes
Feb 24, 2021
|
Test build #135423 has finished for PR 31636 at commit
|
core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
Outdated
Show resolved
Hide resolved
|
+1 for the proposal. Looks correct. |
HyukjinKwon
force-pushed
the
SPARK-34520
branch
from
c0f7203 to
e504096
Compare
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
HyukjinKwon
force-pushed
the
SPARK-34520
branch
from
e504096 to
758cede
Compare
HyukjinKwon
force-pushed
the
SPARK-34520
branch
from
758cede to
a99696c
Compare
|
Addressed comments and resolved the conflicts. |
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Feb 25, 2021
|
Test build #135444 has finished for PR 31636 at commit
|
|
Merged to master. Thanks! |
|
Thank you @dongjoon-hyun! |
|
Test build #135446 has finished for PR 31636 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Mar 1, 2021
### What changes were proposed in this pull request? This is a followup of #31636. There was one place missed in `GangliaSink`, and we should also remove `SecurityManager`. ### Why are the changes needed? To make `GangliaSink` work. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? It was found in the internal it tests in the company I work for. Closes #31688 from HyukjinKwon/SPARK-34520-followup. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
|
Unfortunately, I missed that this is a breaking change due to the following. val sink = Utils.classForName[Sink](classPath)
- .getConstructor(
- classOf[Properties], classOf[MetricRegistry], classOf[SecurityManager])
- .newInstance(kv._2, registry, securityMgr)
+ .getConstructor(classOf[Properties], classOf[MetricRegistry])
+ .newInstance(kv._2, registry) |
|
I'll make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is kind of a followup of #24033 and #30945.
Many of references in
SecurityManagerwere introduced from SPARK-1189, and related usages were removed later from #24033 and #30945. This PR proposes to remove them out.Why are the changes needed?
For better readability of codes.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually complied. GitHub Actions and Jenkins build should test it out as well.