Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token manager - App state caching and init #845

Merged
merged 19 commits into from
May 29, 2019
Merged

Conversation

2color
Copy link
Contributor

@2color 2color commented May 13, 2019

What

  • Use update API to pass an async init function for loading state

Related Issues/PRs

@2color 2color force-pushed the token-manager-use-init-api branch from 77ef679 to 6f077ad Compare May 15, 2019 05:30
@2color 2color mentioned this pull request May 15, 2019
8 tasks
@2color 2color force-pushed the token-manager-use-init-api branch 2 times, most recently from 7afa6a3 to dd7e5ad Compare May 16, 2019 07:15
@2color 2color changed the title [WIP] Token manager: use updated API with caching and init Token manager - App state caching and init May 24, 2019
@2color 2color force-pushed the token-manager-use-init-api branch from dd7e5ad to 4125a8d Compare May 24, 2019 03:57
@luisivan luisivan mentioned this pull request May 27, 2019
25 tasks
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 🎊 🎆 🔥

@2color 2color marked this pull request as ready for review May 29, 2019 09:31
bpierre and others added 2 commits May 29, 2019 13:29
…ng-state

* origin/master:
  Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871)
  Travis: optimizations and refactor to use build stages (#865)
  Update Travis CI badge (#866)
  Hoist common dependencies (#863)
…t-api

* token-manager-loading-state:
  Upgrade @aragon/ui to 0.40.1
  Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871)
  Use a boolean for loading indicator
  Token Manager: update @aragon/api dependencies
  Token Manager: fix lint
  Token Manager: only use the SyncIndicator for the loading states (#873)
  Token Manager: fix loading indicator not being shown when syncing
  Upgrade aragon ui
  Handle custom events before contract events
  Remove unneeded import
  Update apps/token-manager/app/src/script.js
  Travis: optimizations and refactor to use build stages (#865)
  Update Travis CI badge (#866)
  Hoist common dependencies (#863)
  Reduce sync status in background script
  Add syncing states (faked for now)
@2color 2color merged commit ce5dc6f into master May 29, 2019
@2color 2color deleted the token-manager-use-init-api branch May 29, 2019 13:22
MickdeGraaf pushed a commit to MickdeGraaf/aragon-apps that referenced this pull request Jan 28, 2020
* token-manager: use externals and init for caching

* Use updated API which expects an object for every external contract

* Use cached state in init to prevent request

* Add syncing states (faked for now)

* Reduce sync status in background script

* Update apps/token-manager/app/src/script.js

Co-Authored-By: Brett Sun <[email protected]>

* Remove unneeded import

* Handle custom events before contract events

* Upgrade aragon ui

* Token Manager: fix loading indicator not being shown when syncing

* Token Manager: only use the SyncIndicator for the loading states (aragon#873)

* Token Manager: fix lint

* Token Manager: update @aragon/api dependencies

* Cosmetic changes to code

* Add comment about balances

* Use a boolean for loading indicator

* Upgrade @aragon/ui to 0.40.1
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
* token-manager: use externals and init for caching

* Use updated API which expects an object for every external contract

* Use cached state in init to prevent request

* Add syncing states (faked for now)

* Reduce sync status in background script

* Update apps/token-manager/app/src/script.js

Co-Authored-By: Brett Sun <[email protected]>

* Remove unneeded import

* Handle custom events before contract events

* Upgrade aragon ui

* Token Manager: fix loading indicator not being shown when syncing

* Token Manager: only use the SyncIndicator for the loading states (aragon#873)

* Token Manager: fix lint

* Token Manager: update @aragon/api dependencies

* Cosmetic changes to code

* Add comment about balances

* Use a boolean for loading indicator

* Upgrade @aragon/ui to 0.40.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants