-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token manager - App state caching and init #845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77ef679
to
6f077ad
Compare
8 tasks
7afa6a3
to
dd7e5ad
Compare
dd7e5ad
to
4125a8d
Compare
sohkai
reviewed
May 27, 2019
sohkai
reviewed
May 27, 2019
sohkai
reviewed
May 27, 2019
sohkai
approved these changes
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 🎊 🎆 🔥
Co-Authored-By: Brett Sun <[email protected]>
…t-api * token-manager-loading-state: Upgrade @aragon/ui to 0.40.1 Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871) Use a boolean for loading indicator Token Manager: update @aragon/api dependencies Token Manager: fix lint Token Manager: only use the SyncIndicator for the loading states (#873) Token Manager: fix loading indicator not being shown when syncing Upgrade aragon ui Handle custom events before contract events Remove unneeded import Update apps/token-manager/app/src/script.js Travis: optimizations and refactor to use build stages (#865) Update Travis CI badge (#866) Hoist common dependencies (#863) Reduce sync status in background script Add syncing states (faked for now)
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
* token-manager: use externals and init for caching * Use updated API which expects an object for every external contract * Use cached state in init to prevent request * Add syncing states (faked for now) * Reduce sync status in background script * Update apps/token-manager/app/src/script.js Co-Authored-By: Brett Sun <[email protected]> * Remove unneeded import * Handle custom events before contract events * Upgrade aragon ui * Token Manager: fix loading indicator not being shown when syncing * Token Manager: only use the SyncIndicator for the loading states (aragon#873) * Token Manager: fix lint * Token Manager: update @aragon/api dependencies * Cosmetic changes to code * Add comment about balances * Use a boolean for loading indicator * Upgrade @aragon/ui to 0.40.1
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* token-manager: use externals and init for caching * Use updated API which expects an object for every external contract * Use cached state in init to prevent request * Add syncing states (faked for now) * Reduce sync status in background script * Update apps/token-manager/app/src/script.js Co-Authored-By: Brett Sun <[email protected]> * Remove unneeded import * Handle custom events before contract events * Upgrade aragon ui * Token Manager: fix loading indicator not being shown when syncing * Token Manager: only use the SyncIndicator for the loading states (aragon#873) * Token Manager: fix lint * Token Manager: update @aragon/api dependencies * Cosmetic changes to code * Add comment about balances * Use a boolean for loading indicator * Upgrade @aragon/ui to 0.40.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related Issues/PRs