MenuButton: send a message to the current app #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
reviewed
Mar 15, 2019
| @@ -45,6 +42,10 @@ class SwipeContainer extends React.Component { | |||
| initial: [xInitial], | |||
| xy: [x], | |||
| }) => { | |||
| if (!enabled) { | |||
There was a problem hiding this comment.
What was your reasoning for moving this here?
There was a problem hiding this comment.
This is to keep the same node hierarchy: this way, Container and its children tree don’t get unmounted / remounted. It solves the issue of having the current app reloading when the viewport is resized.
It also requires to be set to `true`.
|
👌 |
AquiGorka
pushed a commit
that referenced
this pull request
Mar 20, 2019
…#651) Changes: - Send displayMenuButton (Boolean) to the current app. - Deprecate `menuPanel` in favor of `requestMenu: true` to display the menu panel from an app. - Prevent re-mounting the children of Wrapper on resize.
2color
added a commit
that referenced
this pull request
Apr 3, 2019
* origin/master: (56 commits) Identity - Improve LocalIdentityBadge (#673) Menu panel footer separator (#666) fix(MenuPanel): avoid clickable margin above system apps toggle (#671) Local identities (#656) MenuPanel: add toggle animation to show/hide system apps (#658) Add github workflow for linting/building (#663) Permissions: added system and background app labels (#650) Use the same component to render every app icon (#655) chore: add all contributors and contributing guidelines (#649) Manage the menu button using messages + prevent re-mounting on resize (#651) Update melon (#647) Apps <> System apps separator (#648) Upgrade lint-staged (#646) fix: always leave Kernel as first app (#645) fix: avoid assigning a registry tag if app is not on a registry (#644) chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639) DaoSettings: add bottom margin on app items (#638) Refactor common components (#615) Enforce MenuPanel’s width (#636) Menu panel swipe open close (#606) ...
2color
added a commit
that referenced
this pull request
Apr 3, 2019
* origin/master: (55 commits) Identity - Improve LocalIdentityBadge (#673) Menu panel footer separator (#666) fix(MenuPanel): avoid clickable margin above system apps toggle (#671) Local identities (#656) MenuPanel: add toggle animation to show/hide system apps (#658) Add github workflow for linting/building (#663) Permissions: added system and background app labels (#650) Use the same component to render every app icon (#655) chore: add all contributors and contributing guidelines (#649) Manage the menu button using messages + prevent re-mounting on resize (#651) Update melon (#647) Apps <> System apps separator (#648) Upgrade lint-staged (#646) fix: always leave Kernel as first app (#645) fix: avoid assigning a registry tag if app is not on a registry (#644) chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639) DaoSettings: add bottom margin on app items (#638) Refactor common components (#615) Enforce MenuPanel’s width (#636) Menu panel swipe open close (#606) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
displayMenuButton(Boolean) to the current app.