Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow for linting/building #663

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Add github workflow for linting/building #663

merged 1 commit into from
Mar 28, 2019

Conversation

2color
Copy link
Contributor

@2color 2color commented Mar 26, 2019

What

  • Replicate the travis configuration in Github

Why

@2color
Copy link
Contributor Author

2color commented Mar 26, 2019

Screen Shot 2019-03-26 at 12 46 58 pm

This sort of proves the point about speed.

@sohkai
Copy link
Contributor

sohkai commented Mar 26, 2019

😄 Travis is usually running aragon-apps these days and that's why it seems like it can take forever. For the repos with faster builds though, migrating to Github actions seems like a good choice 👍

@2color
Copy link
Contributor Author

2color commented Mar 26, 2019

😄 Travis is usually running aragon-apps these days and that's why it seems like it can take forever. For the repos with faster builds though, migrating to Github actions seems like a good choice 👍

Might be interesting so see how well the Github actions work for aragon-apps. Github limitations are per repository which is already good news.

@2color 2color merged commit 368bb23 into master Mar 28, 2019
@sohkai sohkai deleted the github-workflow branch March 28, 2019 12:37
2color added a commit that referenced this pull request Apr 3, 2019
* origin/master: (56 commits)
  Identity - Improve LocalIdentityBadge (#673)
  Menu panel footer separator (#666)
  fix(MenuPanel): avoid clickable margin above system apps toggle (#671)
  Local identities (#656)
  MenuPanel: add toggle animation to show/hide system apps (#658)
  Add github workflow for linting/building (#663)
  Permissions: added system and background app labels (#650)
  Use the same component to render every app icon (#655)
  chore: add all contributors and contributing guidelines (#649)
  Manage the menu button using messages + prevent re-mounting on resize (#651)
  Update melon (#647)
  Apps <> System apps separator (#648)
  Upgrade lint-staged (#646)
  fix: always leave Kernel as first app (#645)
  fix: avoid assigning a registry tag if app is not on a registry (#644)
  chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639)
  DaoSettings: add bottom margin on app items (#638)
  Refactor common components (#615)
  Enforce MenuPanel’s width (#636)
  Menu panel swipe open close (#606)
  ...
2color added a commit that referenced this pull request Apr 3, 2019
* origin/master: (55 commits)
  Identity - Improve LocalIdentityBadge (#673)
  Menu panel footer separator (#666)
  fix(MenuPanel): avoid clickable margin above system apps toggle (#671)
  Local identities (#656)
  MenuPanel: add toggle animation to show/hide system apps (#658)
  Add github workflow for linting/building (#663)
  Permissions: added system and background app labels (#650)
  Use the same component to render every app icon (#655)
  chore: add all contributors and contributing guidelines (#649)
  Manage the menu button using messages + prevent re-mounting on resize (#651)
  Update melon (#647)
  Apps <> System apps separator (#648)
  Upgrade lint-staged (#646)
  fix: always leave Kernel as first app (#645)
  fix: avoid assigning a registry tag if app is not on a registry (#644)
  chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639)
  DaoSettings: add bottom margin on app items (#638)
  Refactor common components (#615)
  Enforce MenuPanel’s width (#636)
  Menu panel swipe open close (#606)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants