Add aragonOS API #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built with solidity-docgen.
luisivan
suggested changes
May 16, 2018
| "apm_APMRegistry_APMRegistryConstants", | ||
| "apm_Repo" | ||
| ], | ||
| "APPS": [ |
There was a problem hiding this comment.
Can you make all of these not uppercase? Like Apps, Common, etc.
There was a problem hiding this comment.
Well, those are generated by solidity-docgen. I can also not push those changes, or make another script to convert it to lowercase. i18n/en.json will need to changed too.
| @@ -2,6 +2,9 @@ | |||
| "scripts": { | |||
| "examples": "docusaurus-examples", | |||
| "sync-assets": "rsync -rtu \"$(dirname $(node -p 'require.resolve(\"@aragon/ui\")'))/\" static/aragon-ui", | |||
| "hack_solidity_version": "find ./node_modules/@aragon/os/contracts -name \"*.sol\" -exec sed -i 's/pragma solidity 0.4.18/pragma solidity ^0.4.18/g' {} \\;", | |||
There was a problem hiding this comment.
Instead of merging this PR with all the previously build files, would be cool to just merge the method of building them, and so we don't clutter the repo
|
Closing in favour of #2 |
0xGabi
added a commit
that referenced
this pull request
Dec 1, 2018
…n-on-js-ref Format change of wrapper section on js-ref
0xGabi
pushed a commit
that referenced
this pull request
May 22, 2019
* Update github-guide.md Minor edits (tone + grammar) * Add a couple of HQ images for testing * Replace first three images * Add a couple more hq images * Replace remaining images in 'Editing a document on GitHub' subsection * Add replacement images for 'Your first edit' subsection * Delete gh-5-hq.png Wrong folder * Delete gh-6-hq.png Wrong folder * Add replacement images for 'Your first edit' subsection (correct folder) * Edit 'Your first edit subsection' and link to replacement images * Add replacement images for 'Proposing the file change' and 'Comparing changes' subsections * Link to replacement images in 'Proposing the file change' and 'Comparing changes' subsections + minor edit * Add replacement images for 'Your first pull request' subsection * Add links to replacement images in 'Your first pull request' subsection + minor edits * Add replacement images for 'Adjusting your pull request' subsection * Add final links to replacement images + minor edits * Halve width of zoomed in images * Delete gh-0.png * Delete gh-1.png * Delete gh-10.png * Delete gh-11.png * Delete gh-12.png * Delete gh-13.png * Delete gh-14.png * Delete gh-15.png * Delete gh-16.png * Delete gh-17.png * Delete gh-18.png * Delete gh-19.png * Delete gh-2.png * Delete gh-20.png * Delete gh-3.png * Delete gh-4.png * Delete gh-5.png * Delete gh-6.png * Delete gh-7.png * Delete gh-8.png * Delete gh-9.png * Center img
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built with solidity-docgen.