Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of links in tutorial #12

Merged
merged 2 commits into from
May 21, 2018
Merged

fix of links in tutorial #12

merged 2 commits into from
May 21, 2018

Conversation

Smokyish
Copy link
Contributor

fixing inconsistency of file names to id in files, links in tutorial.md except aragoncli.md which seems to be missing.

@Smokyish Smokyish requested a review from luisivan May 21, 2018 12:05
@@ -1,3 +0,0 @@
[Dolphin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this file? Everything else is cool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, this commit deletes it, you added it here https://github.com/aragon/hack-docs/blob/master/docs/assets/.directory

docs/tutorial.md Outdated
@@ -4,7 +4,7 @@ title: Tutorial
---

# Your first Aragon app
In this guide, we will walk you through creating your first Aragon app using [aragonOS](aragonos-ref.md), [aragon.js](aragonjs-ref.md), [Aragon UI](aragonui-intro.md) and [Aragon CLI](aragoncli.md).
In this guide, we will walk you through creating your first Aragon app using [aragonOS](os-ref.md), [aragon.js](js-ref.md), [Aragon UI](ui-intro.md) and [Aragon CLI](aragoncli.md).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something needs to be done about the cli link

@luisivan luisivan merged commit d421f94 into master May 21, 2018
@Smokyish Smokyish changed the title partial fix of links fix of links in tutorial May 21, 2018
@kernelwhisperer kernelwhisperer deleted the tutorial_links branch March 6, 2019 15:51
unixpi added a commit to unixpi/hack that referenced this pull request May 19, 2019
0xGabi pushed a commit that referenced this pull request May 22, 2019
* Update github-guide.md

Minor edits (tone + grammar)

* Add a couple of HQ images for testing

* Replace first three images

* Add a couple more hq images

* Replace remaining images in 'Editing a document on GitHub' subsection

* Add replacement images for 'Your first edit' subsection

* Delete gh-5-hq.png

Wrong folder

* Delete gh-6-hq.png

Wrong folder

* Add replacement images for 'Your first edit' subsection (correct folder)

* Edit 'Your first edit subsection' and link to replacement images

* Add replacement images for 'Proposing the file change' and 'Comparing changes' subsections

* Link to replacement images in 'Proposing the file change' and 'Comparing changes' subsections + minor edit

* Add replacement images for 'Your first pull request' subsection

* Add links to replacement images in 'Your first pull request' subsection + minor edits

* Add replacement images for 'Adjusting your pull request' subsection

* Add final links to replacement images + minor edits

* Halve width of zoomed in images

* Delete gh-0.png

* Delete gh-1.png

* Delete gh-10.png

* Delete gh-11.png

* Delete gh-12.png

* Delete gh-13.png

* Delete gh-14.png

* Delete gh-15.png

* Delete gh-16.png

* Delete gh-17.png

* Delete gh-18.png

* Delete gh-19.png

* Delete gh-2.png

* Delete gh-20.png

* Delete gh-3.png

* Delete gh-4.png

* Delete gh-5.png

* Delete gh-6.png

* Delete gh-7.png

* Delete gh-8.png

* Delete gh-9.png

* Center img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants