Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart.tooltip function): replaced : chart.tooltip.Content with #137

Closed
wants to merge 1 commit into from

Conversation

aniketmaithani
Copy link

@coveralls
Copy link

coveralls commented Dec 12, 2016

Coverage Status

Coverage remained the same at 81.034% when pulling de6abf5 on aniketmaithani:develop into 9408cee on areski:develop.

@areski
Copy link
Owner

areski commented Dec 12, 2016

related to #128, #118 and #124
There is some work in progress as you can see here:
https://github.com/areski/python-nvd3/pull/128/files
So you might want to create your pull request against the branch nvd3-1.8

@alaalqadi
Copy link

alaalqadi commented Oct 30, 2018

@areski please merge this as i need to reflect the chart.tooltipContentGenerator changes ASAP please

@daadu
Copy link

daadu commented Dec 3, 2019

@aniketmaithani changing chart.tooltipContentGenerator -> tooltip.contentGenerator is half of the problem solved, the arguments in the callback function have changed from function(key, y, e, graph) to function(d, elem) (Check: https://github.com/novus/nvd3/blob/447cce8c180a92fcabd571cca410760deb3a2c1d/src/tooltip.js#L60) therefore the tooltips are not visible and showing Uncaught TypeError: Cannot read property 'point' of undefined error.

@PetrDlouhy PetrDlouhy mentioned this pull request Oct 28, 2020
@areski
Copy link
Owner

areski commented Oct 29, 2020

Fixed by #166

@areski areski closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants