Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix #165 and update dependencies. I find out, that the biggest problem is #118, which is not properly fixed by #137 or anything else, that I found (the error is fixed, but the tooltip doesn't work..
Then I realised, that the new tooltip is much better in
ndv3 1.8.6
and probably solves many thinks, that are tweaked by the tooltip code inpython-nvd3
and contains more information (like series color). The default tooltip works very good in most cases. The only thing, that it does not solve is to have custom date format for tooltip different than xAxisFormat.So I tried to fix that by using
header/keyFormatter
functions. It works, but differently for each chart type. So the resulting code have many conditions, and should be properly tested on different chart types (I tested on my charts, but all are have date in x axis).