Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pco allocation strategy for ec2 fleet #3502

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Mar 1, 2023

Fixes #

Description

  • Spot Fleet generally uses lowerCamelCased allocation strategy names (i.e. priceCapacityOptimized), whereas EC2 Fleet generally uses kebab-cased allocation strategy names (i.e. price-capacity-optimized). Change to use the EC2 Fleet recommended way.

How was this change tested?

  • manual testing of spot nodes in a cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner March 1, 2023 15:30
@bwagner5 bwagner5 requested a review from jonathan-innis March 1, 2023 15:30
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0ca09ad
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63ff6f9fbb5d110008b34324

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 658e8b1 into aws:main Mar 1, 2023
@bwagner5 bwagner5 deleted the fix-pco branch March 1, 2023 15:43
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Merge in DEL/karpenter-fork from DELIVERY-8215_update_to_0.27.0 to main

* commit 'c5b7235218996a4579180ab4811afe82c884ee9f':
  chore: Bump `karpenter-core` to latest (aws#3548)
  BREAKING CHANGE: Convert preferred anti-affinity to required anti-affinity (aws#3543)
  test: Fix daemonset preemption in testing to be `PreemptLowerPriority` (aws#3544)
  chore: Move instance to providers (aws#3509)
  docs: cleanup `aws.tags` and `specs.tags` docs (aws#3540)
  docs: Add Canva to Adopters (aws#3541)
  fix: fixed an issue where only using owners in amiSelector resulted in a failure (aws#3533)
  feat: add featureGates.driftEnabled to helm chart values (aws#3521)
  chore: Release v0.26.1 (aws#3519)
  fix: inflight IP tracking when CreateFleet returns an error (aws#3515)
  chore: add more integration test logs (aws#3511)
  chore(deps): bump github.com/aws/aws-sdk-go from 1.44.195 to 1.44.212 in /test (aws#3508)
  test: if the test fails, identify the names of the created nodes (aws#3504)
  chore: Move instancetypes to providers (aws#3478)
  feat: Added additional topology spread constraint (aws#3190)
  chore: Release v0.26.0 (aws#3506)
  test: fix test panic (aws#3503)
  chore: fix pco allocation strategy for ec2 fleet (aws#3502)
  docs: Add Docker to adopters list (aws#3500)
  Typo (aws#3487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants