Crude ASG/MNG implementations #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 14, 2020 20:26
otherwise it doesn't work :-)
ellistarn
reviewed
Aug 19, 2020
added 6 commits
August 19, 2020 17:12
Per https://github.com/aws/aws-sdk-go-v2/blob/master/CHANGELOG.md it's about to go thru a major overhaul, so seems like we should stick with v1 for now. Also made one change from the PR #4 CR
per PR/4 feedback
ellistarn
reviewed
Aug 20, 2020
ellistarn
approved these changes
Aug 20, 2020
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Merge in DEL/karpenter-fork from DELIVERY-8215_update_to_0.27.0 to main * commit 'c5b7235218996a4579180ab4811afe82c884ee9f': chore: Bump `karpenter-core` to latest (aws#3548) BREAKING CHANGE: Convert preferred anti-affinity to required anti-affinity (aws#3543) test: Fix daemonset preemption in testing to be `PreemptLowerPriority` (aws#3544) chore: Move instance to providers (aws#3509) docs: cleanup `aws.tags` and `specs.tags` docs (aws#3540) docs: Add Canva to Adopters (aws#3541) fix: fixed an issue where only using owners in amiSelector resulted in a failure (aws#3533) feat: add featureGates.driftEnabled to helm chart values (aws#3521) chore: Release v0.26.1 (aws#3519) fix: inflight IP tracking when CreateFleet returns an error (aws#3515) chore: add more integration test logs (aws#3511) chore(deps): bump github.com/aws/aws-sdk-go from 1.44.195 to 1.44.212 in /test (aws#3508) test: if the test fails, identify the names of the created nodes (aws#3504) chore: Move instancetypes to providers (aws#3478) feat: Added additional topology spread constraint (aws#3190) chore: Release v0.26.0 (aws#3506) test: fix test panic (aws#3503) chore: fix pco allocation strategy for ec2 fleet (aws#3502) docs: Add Docker to adopters list (aws#3500) Typo (aws#3487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love this implementation but thought I'd get some feedback. I have tested it lightly with a separate (not checked in) test that actually works on real ASGs and MNGs