Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup aws.tags and specs.tags docs #3540

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Mar 6, 2023

Description
Update docs for aws.tags (global tags).

New version of #3530. Applied changes retrospectively to previous versions' docs.

How was this change tested?

  • n/a

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@robertd robertd requested a review from a team as a code owner March 6, 2023 17:55
@robertd robertd requested a review from spring1843 March 6, 2023 17:55
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit d1bfbfb
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64062900a836f40007e133ac
😎 Deploy Preview https://deploy-preview-3540--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@robertd
Copy link
Contributor Author

robertd commented Mar 6, 2023

@jonathan-innis New version of #3530. Applied changes retrospectively to previous versions' docs.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit e52a4ca into aws:main Mar 6, 2023
@robertd robertd deleted the docs branch March 7, 2023 07:19
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Merge in DEL/karpenter-fork from DELIVERY-8215_update_to_0.27.0 to main

* commit 'c5b7235218996a4579180ab4811afe82c884ee9f':
  chore: Bump `karpenter-core` to latest (aws#3548)
  BREAKING CHANGE: Convert preferred anti-affinity to required anti-affinity (aws#3543)
  test: Fix daemonset preemption in testing to be `PreemptLowerPriority` (aws#3544)
  chore: Move instance to providers (aws#3509)
  docs: cleanup `aws.tags` and `specs.tags` docs (aws#3540)
  docs: Add Canva to Adopters (aws#3541)
  fix: fixed an issue where only using owners in amiSelector resulted in a failure (aws#3533)
  feat: add featureGates.driftEnabled to helm chart values (aws#3521)
  chore: Release v0.26.1 (aws#3519)
  fix: inflight IP tracking when CreateFleet returns an error (aws#3515)
  chore: add more integration test logs (aws#3511)
  chore(deps): bump github.com/aws/aws-sdk-go from 1.44.195 to 1.44.212 in /test (aws#3508)
  test: if the test fails, identify the names of the created nodes (aws#3504)
  chore: Move instancetypes to providers (aws#3478)
  feat: Added additional topology spread constraint (aws#3190)
  chore: Release v0.26.0 (aws#3506)
  test: fix test panic (aws#3503)
  chore: fix pco allocation strategy for ec2 fleet (aws#3502)
  docs: Add Docker to adopters list (aws#3500)
  Typo (aws#3487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants