Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing Dev into Test #851

Merged
merged 67 commits into from
Nov 17, 2022
Merged

Pushing Dev into Test #851

merged 67 commits into from
Nov 17, 2022

Conversation

AlfredRosenthal
Copy link
Contributor

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

NickPhura and others added 30 commits May 9, 2022 12:36
… Restoration, Adjust access request approval to account for existing bceid-basic-business identity sources (#771)

- Port improved user access request functionality from Restoration
  - Better/fixed handling for approving/denying user requests
  - Adjust access request approval to account for existing bceid-basic-business identity sources
- Existing access requests created before we accounted for bceid-basic-and-business identity sources should no longer throw an error when trying to approve/deny them.
…er (#770)

* BHBC-1730: Use centerOfMass instead of centroid for project area center point.
* BHBC-1736: Tighten qualification for string truncating

* BHBC-1736: Fix null coalesce

* BHBC-1736: Change variable name to be more descriptive
- account for the fact that openapi enums are case sensitive
* Create toDraft.yml

* remove dependency
Bumps [sqlite3](https://github.com/TryGhost/node-sqlite3) from 5.0.2 to 5.0.8.
- [Release notes](https://github.com/TryGhost/node-sqlite3/releases)
- [Changelog](https://github.com/TryGhost/node-sqlite3/blob/master/CHANGELOG.md)
- [Commits](TryGhost/node-sqlite3@v5.0.2...v5.0.8)

---
updated-dependencies:
- dependency-name: sqlite3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick Phura <[email protected]>
* Fixed horizontal autoscaler and consolidate deployment files

* Some config changes

* Forgot one

* fix

* Set utilization as portion of reques, not maximum
- Fix cypress tests
- Update n8n version/config
* BHBC-1755: Add backbone api env var and platform-service.
- Remove clamav hardcoded default values
- Improve checking for required clamav env vars before initializing scanner
- Add missing clamav env vars to api deployment yaml
Bumps [convict](https://github.com/mozilla/node-convict) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](mozilla/node-convict@v6.2.2...v6.2.3)

---
updated-dependencies:
- dependency-name: convict
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixed an error that occurred when attempting to edit the ‘Purpose and Methodology’ section of a survey.

 - Updated schema validation for GET on purpose_methodology update endpoint.
 - BHBC-1783: Add API response validation testing to update endpoint (work in progress).
 - BHBC-1783: Amend platform-service and its test file w 'dwc/submission/create' endpoint.
…Dev (#793)

 - Replace hardcoded URLs in Resources page by implementing env. vars (BHBC-1775)
 - Fix API response validation bugs for Project Drafts (BHBC-1809)
BHBC-1796: Bug fix - Observation points not displaying on map
BHBC-1810: Bug fix - Transformation of large template file crashes API in Openshift
Tech debt: survey-service
EML: major updates to EML creation code
Tech Debt: Fix Cypress Tests (#800)
Bug fix for survey attachment view details
…survey create/update (#803)

BHBC-1201: Push project/survey metadata (EML) to backbone on create/update
 - Project and survey UI no longer include publish button
 - API no longer has endpoints for publishing
System admin button + endpoint to submit project and survey EML + Observation data to BioHub Backbone.
…gs, enable biohub submission env var for dev. (#806)

- Handle error popup for BioHub Submit
- remove some old logs
- enable biohub submission env var for dev
KjartanE and others added 25 commits September 23, 2022 16:42
Refactor create project page to a single form, removing the multi-step wizard
- Adjusted permit model for model 1.2
- Adjusted db function project deletion routines
- Added smoke test file
- Purge old permit code from all project related components (frontend and backend)
- Add CustomFieldArray Component
- Move permit components/logic to Survey (from Project)
Add 2 new items to the agency codes list
Removed all public views/ pages and supporting tests/ SQL. All unauthenticated users will now be directed to the login page
…#830)

 - addition of species descriptor to survey occurrence templates
- addition of templates concept to survey summary details

- adjusted file name

Co-authored-by: Kjartan <[email protected]>
BHBC-1937: Ported MapContainer improvements over from platform:
 * Created new React components to encapsulate Map components and `wfs-utils` helper for rendering and selecting regional/mu layers
 * Updated tests and added type defs for map util functions.
Refactored Darwin core submission endpoint, added column to track Darwin core data as JSON

Co-authored-by: Anissa Agahchen <[email protected]>
Fixed keycloak envs so they are passed properly to API
Renamed migration to maintain standards
Added wrapped function to catch any errors thrown by database functions
Fixed keycloak URL for SIMS/ BioHub intake
…y result templates (#834)

 * BHBC-1976: Enhance summary template validation to get validation schema from database.
 * Created a service and repository file for summary template validation.
 * Determine validation schema by performing search on template name, version and taxonomic code.
 * Read in template name and version from XLSX custom properties.
Prepping dev for test release
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #851 (c577394) into test (b99f8cb) will increase coverage by 0.41%.
The diff coverage is 87.61%.

@@            Coverage Diff             @@
##             test     #851      +/-   ##
==========================================
+ Coverage   73.05%   73.47%   +0.41%     
==========================================
  Files         353      351       -2     
  Lines       12905    11793    -1112     
  Branches     2317     2130     -187     
==========================================
- Hits         9428     8665     -763     
+ Misses       2994     2675     -319     
+ Partials      483      453      -30     
Impacted Files Coverage Δ
api/src/__mocks__/db.ts 92.59% <0.00%> (-7.41%) ⬇️
api/src/app.ts 0.00% <0.00%> (ø)
api/src/constants/codes.ts 100.00% <ø> (ø)
api/src/constants/notifications.ts 100.00% <ø> (ø)
api/src/models/occurrence-create.ts 100.00% <ø> (ø)
api/src/models/project-create.ts 100.00% <ø> (ø)
api/src/models/summaryresults-create.ts 0.00% <0.00%> (-21.06%) ⬇️
api/src/models/user.ts 63.63% <ø> (-9.70%) ⬇️
api/src/openapi/schemas/administrative-activity.ts 100.00% <ø> (ø)
api/src/openapi/schemas/draft.ts 100.00% <ø> (ø)
... and 337 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlfredRosenthal AlfredRosenthal marked this pull request as ready for review November 17, 2022 01:39
@AlfredRosenthal AlfredRosenthal merged commit 61f8cd8 into test Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants