Various changes #601
Various changes #601
Conversation
As well as avoiding a HTML redirect for a link to FAQ
|
|
||
| {{ members_macro::members_grid(members=members) }} |
There was a problem hiding this comment.
| {{ members_macro::members_grid(members=members) }} | |
| {{ members_macro::members_grid(members=members | filter(attribute="sponsor")) }} |
Only members with a sponsor link should be displayed here
| buckets[2].push(org_member); | ||
| } else { | ||
| buckets[3].push(org_member); |
There was a problem hiding this comment.
| buckets[2].push(org_member); | |
| } else { | |
| buckets[3].push(org_member); | |
| buckets[3].push(org_member); | |
| } else { | |
| buckets[2].push(org_member); |
| {% set members = load_data(path="org_members.json") %} | ||
|
|
||
| {{ members_macro::members_grid(members=members) }} |
There was a problem hiding this comment.
| {% set members = load_data(path="org_members.json") %} | |
| {{ members_macro::members_grid(members=members) }} | |
| {% set members = load_data(path="org_members.json", required=false) %} | |
| {% if members %}{{ members_macro::members_grid(members=members) }}{% endif %} |
| {% endif %} | ||
| </div> | ||
| {% endif %} | ||
| {% set members = load_data(path="org_members.json") %} |
There was a problem hiding this comment.
| {% set members = load_data(path="org_members.json") %} | |
| {% set members = load_data(path="org_members.json", required=false) %} |
There was a problem hiding this comment.
It is required in practice though? This page will be empty if we don't generate the JSON files
There was a problem hiding this comment.
to build the full website yup, but for people who only want to work on part of it, like the book, they don't need it and we want to avoid the need for them to run the script
| Members<a class="anchor-link" href="#org-members">#</a> | ||
| </h2> | ||
| {% else %} | ||
| {% set members = load_data(path="community_members.json") %} |
There was a problem hiding this comment.
| {% set members = load_data(path="community_members.json") %} | |
| {% set members = load_data(path="community_members.json", required=false) %} |
| {% endif %} | ||
|
|
||
| {{ members_macro::members_grid(members=members) }} |
There was a problem hiding this comment.
| {{ members_macro::members_grid(members=members) }} | |
| {% if members %}{{ members_macro::members_grid(members=members) }}{% endif %} |
There was a problem hiding this comment.
This existed as an "actual page" because we want to be able to link to bevyengine.org/faq as a nice sharable / short link to the github discussions query
| {% for subsection in section.subsections %} | ||
| {% set section = get_section(path=subsection) %} | ||
|
|
||
| <a class="anchor-target" id="{{ section.title | slugify }}"></a> |
There was a problem hiding this comment.
The sidebar links stop working with this change
|
I'll address all the comments next week, thanks for the comments! |
|
Many of these changes have been incorporated elsewhere. Thanks! |
Some changes while looking at the repo after getzola/zola@cd90fd0
The biggest one is the change in the community building where it was using page for members for no discernable reasons.
load_datais made for exactly that kind of use case. By creating pages, you end up with stuff like that https://bevyengine.org/community/donate/cart/ but Zola should warn on that.You could skip 90% of the code by just storing the members in a single TOML file for each category as an array of tables though.
Note: some of my changes might need me to release Zola 0.17.2 before it works.