-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zola #719
Update zola #719
Conversation
The 0.16.1 version of zola has a bug when using colocated_path, this prevents usage of image resolution in bevyengine#710 Solution: upgrade the zola action we use. The diff of the github action is available at: shalzz/zola-deploy-action@v0.16.1-1...v0.17.2 Unblocks bevyengine#710
hhhmm, something broke with the update |
some changes from #601 may be needed |
@nicopap, do you still plan on working toward updating this PR? If not I'd like to adopt this PR and work on this. |
Few things that may need changed in order to update to 0.17:
Compiled from Zola's changelog and grass / Dart Sass's breaking changes. |
I don't think any of these affect the site (outside of updating the |
I believe the Sass division operator is use, but I need to double-check. |
Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that. |
Mm, fun. /sar I'll take that as an okay for adopting this PR then. What's the fifth repository? I can guess |
Well, it might very well be 4 (four). It's not just a question of 4 repositories, but also the relevant code being spread accross several config files on each of those repositories, each with their own special structure. I'm glad you are taking the rein though. Thank you so much! Closed in favor of #1018 |
The 0.16.1 version of zola has a bug when using colocated_path, this prevents usage of image resolution in #710
Solution: upgrade the zola action we use.
The diff of the github action is available at:
shalzz/zola-deploy-action@v0.16.1-1...v0.17.2
Unblocks #710