Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zola #719

Closed
wants to merge 1 commit into from
Closed

Update zola #719

wants to merge 1 commit into from

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Jul 16, 2023

The 0.16.1 version of zola has a bug when using colocated_path, this prevents usage of image resolution in #710

Solution: upgrade the zola action we use.

The diff of the github action is available at:

shalzz/zola-deploy-action@v0.16.1-1...v0.17.2

Unblocks #710

The 0.16.1 version of zola has a bug when using colocated_path, this
prevents usage of image resolution in bevyengine#710

Solution: upgrade the zola action we use.

The diff of the github action is available at:

shalzz/zola-deploy-action@v0.16.1-1...v0.17.2

Unblocks bevyengine#710
@nicopap nicopap marked this pull request as draft July 16, 2023 15:26
@nicopap
Copy link
Contributor Author

nicopap commented Jul 16, 2023

hhhmm, something broke with the update

@mockersf
Copy link
Member

some changes from #601 may be needed

@TrialDragon
Copy link
Member

TrialDragon commented Feb 16, 2024

@nicopap, do you still plan on working toward updating this PR? If not I'd like to adopt this PR and work on this.

@BD103
Copy link
Member

BD103 commented Feb 16, 2024

Few things that may need changed in order to update to 0.17:

  • Built-in shortcodes have been removed. Do we use any?
  • index.md and _index.md file can no longer be in the same folder. This can be checked by simple building with Zola 0.17.
  • If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing?
  • author is now a first-class property, and can be moved out from the [extra] table in various articles under the news folder.
  • / is Sass is not longer a division operator. It has been changed to now be a list separator. There are two solutions to this:
    • Wrap divisions in calc: 12px / 4px to calc(12px / 4px).
    • Use math.div: 12px / 4px to math.div(12px, 4px).

Compiled from Zola's changelog and grass / Dart Sass's breaking changes.

@TrialDragon
Copy link
Member

TrialDragon commented Feb 17, 2024

Few things that may need changed in order to update to 0.17:

* Built-in shortcodes have been removed. Do we use any?

* `index.md` and `_index.md` file can no longer be in the same folder. This can be checked by simple building with Zola 0.17.

* If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing?

* `author` is now a first-class property, and can be moved out from the `[extra]` table in various articles under the `news` folder.

* `/` is Sass is **not longer a division operator**. It has been changed to now be a list separator. There are two solutions to this:
  
  * Wrap divisions in `calc`: `12px / 4px` to `calc(12px / 4px)`.
  * Use `math.div`: `12px / 4px` to `math.div(12px, 4px)`.

Compiled from Zola's changelog and grass / Dart Sass's breaking changes.

I don't think any of these affect the site (outside of updating the author property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regarding wgsl and shell highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)

@BD103
Copy link
Member

BD103 commented Feb 17, 2024

I don't think any of these affect the site (outside of updating the author property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regarding wgsl and shell highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)

I believe the Sass division operator is use, but I need to double-check.

@nicopap
Copy link
Contributor Author

nicopap commented Feb 18, 2024

Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.

@TrialDragon
Copy link
Member

Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.

Mm, fun. /sar I'll take that as an okay for adopting this PR then. What's the fifth repository? I can guess bevy-website, bevy (examples), bevy-assets, and bevy-community (used for peoples page).

@nicopap
Copy link
Contributor Author

nicopap commented Feb 19, 2024

Well, it might very well be 4 (four). It's not just a question of 4 repositories, but also the relevant code being spread accross several config files on each of those repositories, each with their own special structure.

I'm glad you are taking the rein though. Thank you so much!

Closed in favor of #1018

@nicopap nicopap closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants