Bump Github Actions versions #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The master branch is no longer updated, it has since been migrated to be named main. Additionally, it is better to target a specific version to avoid breaking changes.
Now the version numbers are all consistent at v4. Previously, some were v3 and others were the unmaintained master branch (renamed to main).
Was previously as mix of v2 and v3. The only notable breaking changes were NodeJS version bump, which does not affect us.
Bump to v6. There are only two breaking changes, both of which don't affect anything else. The first changes the default email and name of the pull request created. The second cleans up some Git config, which is unused by us.
alice-i-cecile
added
A-Build-System
dependencies
mockersf
approved these changes
Feb 5, 2024
|
LGTM. I also looked at what's involved when updating shalzz/zola-deploy-action. The main concern is that it's updating Zola to v0.18.0 so we need to take a close look to this Zola version release changes before the bump |
RomainMazB
approved these changes
Feb 5, 2024
Ok! I'll test that out, but it will definitely be in a separate PR. Thanks for the insight :) |
JMS55
pushed a commit
to JMS55/bevy-website-1
that referenced
this pull request
Feb 13, 2024
Co-authored-by: François <[email protected]>
RobWalt
pushed a commit
to RobWalt/bevy-website
that referenced
this pull request
Feb 13, 2024
Co-authored-by: François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the versions of actions used by CI. The specific actions being updated are split by commit. They are:
actions/checkoutto v4 (b9166c2)actions/upload-artifactandactions/download-artifactto v4 (c1cc6af)actions/cacheto v4 (bc782e7)peter-evans/create-pull-requestto v6 (459e9c9)A few versions were inconsistent across the project, so this fixes that too. I don't believe any of the breaking changes affect us, since most of the changes were bumping the NodeJS runtime to version 20. The other breaking changes are documented in the commit descriptions.
Many actions were targeting the
masterbranch. Sincemasterwas renamed tomainfor all of those projects, runs were pulling what is equivalent of a random out-of-date commit from the repositories. I updated them to target actual releases, to avoid breaking changes.The only action I left outdated (that I'm aware of) is
shalzz/zola-deploy-actionsince the release notes are more confusing and I didn't want to break anything. That may come in another PR.