-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to django-sodar-core v1.0 #1922
Comments
Two tests currently failing in local dev:
NOTE: At the time of writing all iRODS tests fail in CI, as I'm still using our iRODS 4.2 image which is incompatible with postgres v16. |
All tests now working locally with iRODS v4.3.1. |
I fixed iRODS-related tests in CI by temporarily adding a separate PostgreSQL v11 server to be used by iRODS. This can be removed once I have a stable iRODS 4.3 image and switch to using that in CI. |
The
|
Done and merged into v1.0. A couple of issues remain, I will split them into separate tasks as applicable. |
This one will be a bit more involved due to the large amount of breaking changes. Keeping a note of them here.
This requires first doing bihealth/irods-docker#16 and bihealth/sodar-docker-compose#34. (Edit: not really, some client issues require these to be developed simultaneously)
Tasks
CORE_API_*
referencesDeleteView
classes breaking with Django v4.xUpdateN/AAppSettingAPI
app_name
arguments intoplugin_name
get_object_link()
return data toPluginObjectLink
search()
return data toPluginSearchResult
UpdateN/AProjectModifyPluginMixin
method signatures forplugin_name
AUTH_LDAP*_USER_SEARCH_BASE
Django settingsSet(1)ATOMIC_REQUESTS
toTrue
and ensure all worksUpdate email sending for settings link usage where applicableN/Abroker_connection_retry
setting in Celery setup (see comments)Documentation Updates
Admin alerts email sendingDocumented in SODAR Corecheckusers
management commandOIDC support (mention status of iRODS support)Add OIDC documentation once iRODS is supportedNotes
The text was updated successfully, but these errors were encountered: