Skip to content

Commit

Permalink
C2R: Remove env vars/opts with no effect
Browse files Browse the repository at this point in the history
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore
  (rpm -Va runs always and a warning is printed when the option is used saying
  that it has no effect)
-- Related: oamg/convert2rhel#875
- The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed
-- Related: oamg/convert2rhel#1102
- The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor
  of CONVERT2RHEL_INCOMPLETE_ROLLBACK
-- Related: oamg/convert2rhel#1147
- The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var
  recognized by convert2rhel. It is an ID of one of convert2rhel
  Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION
  which is in recent versions (2.x) removed in favor of
  CONVERT2RHEL_ALLOW_OLDER_VERSION.
  • Loading branch information
bocekm committed Feb 7, 2025
1 parent 3ef2796 commit 1084cba
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
3 changes: 0 additions & 3 deletions c2r_convert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
gather_facts: true
become: true
environment:
CONVERT2RHEL_DISABLE_TELEMETRY: 1
# CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK: 1
CONVERT2RHEL_INCOMPLETE_ROLLBACK: 1
CONVERT2RHEL_LATEST_VERSION: 0
vars:
rhsm_username: ""
rhsm_password: ""
Expand Down
3 changes: 1 addition & 2 deletions group_vars/control/worflow_job_templates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ controller_workflows:
description: Workflow for Snapshot and Pre-conversion analysis of EL systems
extra_vars:
org_id: "Default_Organization"
convert_convert2rhel_opts: '--no-rpm-va'
convert_reboot_requested: true
convert_convert2rhel_opts: ''
lvm_snapshots_action: create
inventory: EC2 Dynamic Inventory
state: present
Expand Down

0 comments on commit 1084cba

Please sign in to comment.