[RHELC-1397] Always save conversion facts file #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venefilyn
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
- Coverage 94.89% 94.84% -0.06%
==========================================
Files 49 49
Lines 4549 4541 -8
Branches 809 806 -3
==========================================
- Hits 4317 4307 -10
- Misses 156 158 +2
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jochapma
added
the
tests/tier0
r0x0d
approved these changes
Feb 19, 2024
|
/packit test --labels tier0 |
1 similar comment
|
/packit test --labels tier0 |
bocekm
requested changes
Feb 20, 2024
tests/integration/tier0/non-destructive/basic-sanity-checks/test_basic_sanity_checks.py
Outdated
Show resolved
Hide resolved
.../non-destructive/single-yum-transaction-validation/test_single_yum_transaction_validation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Michal Bocek <[email protected]>
r0x0d
approved these changes
Feb 21, 2024
|
/packit test --labels tier0 |
bocekm
approved these changes
Feb 21, 2024
Merged
jochapma
added a commit
to jochapma/convert2rhel
that referenced
this pull request
Mar 11, 2024
* Always save conversion facts. * Remove unit tests related to disabling telemetry. * Remove disabled telemetry checks from integration tests. * Apply suggestions from code review Co-authored-by: Michal Bocek <[email protected]> --------- Co-authored-by: Michal Bocek <[email protected]>
bocekm
reviewed
Apr 17, 2024
| loggerinst.info("Skipping, telemetry disabled.") | ||
| """Print information about data collection and ask for acknowledgement.""" | ||
| loggerinst.info( | ||
| "The convert2rhel utility generates a /etc/rhsm/facts/convert2rhel.fact file that contains the below data" |
There was a problem hiding this comment.
The path is wrong. Fixed in #1183.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION. Also, the convert_reboot_requested should not be needed when it comes to just analyzing the system (convert2rhel analyze). The --restart convert2rhel option is heeded just when it comes to the actual conversion. And, when the workshop executes and older convert2rhel version (on purpose) then the pre-conversion analysis ends up with two inhibitors: - Outdated convert2rhel version detected - Outdated packages detected This commit adds the related environment variables to override the inhibitors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always create the conversion facts file.
This change removes the
CONVERT2RHEL_DISABLE_TELEMETRYenvironment variable.Jira Issues: RHELC-1397
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant