[RHELC-1430, RHELC-1500] Rename incomplete rollback envvar #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are moving away from using the word UNSUPPORTED in environment variables as it is confusing and not very descriptive of what is unsupported. Since this relates to the tool itself not supporting it in a predictable way, we are renaming mentions of the word unsupported. This change has to do with renaming CONVERT2RHEL_UNSUPPORTED INCOMPLETE_ROLLBACK to CONVERT2RHEL_INCOMPLETE_ROLLBACK CONVERT2RHEL_INCOMPLETE_ROLLBACK means that we can garantee a rollback will be successful on a potential failure and user would have to specify the environment variable themselves to understand this to not blame the tool. This change does not do anything else and no backwards compatibility is considered as it is intended to be changed in a major version change. Related RHELC-1430
Venefilyn
added
kind/breaking
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 51 51
Lines 4594 4594
Branches 810 810
=======================================
Hits 4384 4384
Misses 134 134
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Venefilyn
changed the title
|
/packit test |
r0x0d
approved these changes
Mar 18, 2024
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
|
Majority of test fails seem unrelated |
danmyway
changed the title
Merged
hosekadam
changed the title
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION.
bocekm
added a commit
to bocekm/automated-satellite
that referenced
this pull request
Feb 7, 2025
- The --no-rpm-va option has no effect with `convert2rhel analysis` anymore (rpm -Va runs always and a warning is printed when the option is used saying that it has no effect) -- Related: oamg/convert2rhel#875 - The CONVERT2RHEL_DISABLE_TELEMETRY env var was removed -- Related: oamg/convert2rhel#1102 - The CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACK was removed in favor of CONVERT2RHEL_INCOMPLETE_ROLLBACK -- Related: oamg/convert2rhel#1147 - The CONVERT2RHEL_LATEST_VERSION env var has never been a valid env var recognized by convert2rhel. It is an ID of one of convert2rhel Actions. A similar env var to this is CONVERT2RHEL_UNSUPPORTED_VERSION which is in recent versions (2.x) removed in favor of CONVERT2RHEL_ALLOW_OLDER_VERSION. Also, the convert_reboot_requested should not be needed when it comes to just analyzing the system (convert2rhel analyze). The --restart convert2rhel option is heeded just when it comes to the actual conversion. And, when the workshop executes and older convert2rhel version (on purpose) then the pre-conversion analysis ends up with two inhibitors: - Outdated convert2rhel version detected - Outdated packages detected This commit adds the related environment variables to override the inhibitors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving away from using the word UNSUPPORTED in environment
variables as it is confusing and not very descriptive of what is
unsupported. Since this relates to the tool itself not supporting it in
a predictable way, we are renaming mentions of the word unsupported.
This change has to do with renaming
CONVERT2RHEL_UNSUPPORTED_INCOMPLETE_ROLLBACKto
CONVERT2RHEL_INCOMPLETE_ROLLBACKCONVERT2RHEL_INCOMPLETE_ROLLBACKmeans that we can garantee a rollbackwill be successful on a potential failure and user would have to specify
the environment variable themselves to understand this to not blame the
tool.
This change does not do anything else and no backwards compatibility is
considered as it is intended to be changed in a major version change.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant