Skip to content

Commit

Permalink
Update Dangerfile to be less noisy, close Instagram#792
Browse files Browse the repository at this point in the history
Summary:
Issue fixed: Instagram#792

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes Instagram#795

Differential Revision: D5132076

Pulled By: rnystrom

fbshipit-source-id: 7d68f842e0244d6c6184982ee434dc4da22cc7c6
  • Loading branch information
Iron-Ham authored and facebook-github-bot committed May 25, 2017
1 parent 98218ca commit a5d5213
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ warn("Big PR") if git.lines_of_code > 500

# Changelog entries are required for changes to library files.
no_changelog_entry = !git.modified_files.include?("CHANGELOG.md")
if has_source_changes && no_changelog_entry && not_declared_trivial
if has_source_changes && no_changelog_entry && not_declared_trivial && git.lines_of_code > 10
fail("Any source code changes should have an entry in CHANGELOG.md.")
end

Expand Down

0 comments on commit a5d5213

Please sign in to comment.