Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked items alignment is off with introduction of share button #15403

Closed
srirambv opened this issue Apr 21, 2021 · 6 comments · Fixed by brave/brave-core#8673
Closed

Blocked items alignment is off with introduction of share button #15403

srirambv opened this issue Apr 21, 2021 · 6 comments · Fixed by brave/brave-core#8673
Labels
bug design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Blocked items alignment is off with introduction of share button

Steps to reproduce

  1. Install 1.25.31 x64 nightly build
  2. Visit a site
  3. Open Shields blocked items are misaligned due to share button

Actual result

Expected result

Properly aligned stats on shields

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.25.31 x64 nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya @alexsafe

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Apr 21, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 21, 2021
@GeetaSarvadnya
Copy link

Reproduced the issue in Samsung Galaxy J3 version 5.1.1 bravearm 1.25.28 nightly build
Screenshot_2021-04-27-11-20-26

@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2021

Moved this into the 1.26.x milestone as it was merged as per brave/brave-core#8673.

@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2021

Created #15635 as a follow up as brave/brave-core#8673 didn't completely fix the alignment issues.

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.25.57 x64 Beta build

  • Verified blocked item and text is better aligned after the fix


Verified on tablet but found the issue still persisted so logged follow up issue #15777

@kjozwiak
Copy link
Member

Probably a good idea to recheck these as it was reverted from 1.25.x which is the channel most of the QA was done for this feature. Depending on a fix, this might go into a 1.25.x HF.

@srirambv
Copy link
Contributor Author

srirambv commented Jun 1, 2021

Verification passed on OnePlus 6T with Android 10 running 1.26.46 x64 Beta build

  • Verified blocked item and text is better aligned after the fix

Verification passed on Samsung Tab A with Android 10 running 1.26.46 x64 Beta build

  • Verified blocked item and text is better aligned after the fix

OnePlus 6T Samsung Tab A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants