Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fixes pixelated icons and the shields layout with the share stats #8673

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Apr 29, 2021

Resolves brave/brave-browser#15403

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Described in the issue

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 29, 2021
@alexsafe alexsafe added this to the 1.26.x - Nightly milestone Apr 29, 2021
@alexsafe alexsafe requested a review from deeppandya April 29, 2021 16:15
@alexsafe alexsafe self-assigned this Apr 29, 2021
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsafe alexsafe merged commit c5a792b into master Apr 29, 2021
@alexsafe alexsafe deleted the shields-share-layout branch April 29, 2021 19:27
@alexsafe alexsafe changed the title [Android] fixes pixelated icons and the shields layout with the share… [Android] fixes pixelated icons and the shields layout with the share stats Apr 30, 2021
brave-builds pushed a commit that referenced this pull request Apr 30, 2021
@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2021

Went through the above using Samsung S10+ running Android 11:

1.23.74 Chromium: 90.0.4430.85 (Current Release) 1.25.42 Chromium: 90.0.4430.85 (Before Fix) 1.26.7 Chromium: 90.0.4430.93 (After Fix)
Screenshot_20210514-130334_Brave Screenshot_20210514-124444_Brave - Nightly Screenshot_20210514-125957_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked items alignment is off with introduction of share button
3 participants