Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocked items within shields misaligned due to sharing button - follow up to #15403 #15635

Open
kjozwiak opened this issue May 5, 2021 · 0 comments
Assignees
Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented May 5, 2021

Description

Creating a follow up for #15403. The fix from brave/brave-core#8673 improved the text but the Shields alignment still looks a bit off compared to what we have in the current 1.23.x release. The toggle and the bottom content of Shields doesn't look aligned as per the below example.

Examples of current alignment: brave/brave-core#8673 (comment)

Steps to reproduce

  1. launch 1.26.7 Chromium: 90.0.4430.93
  2. open a random website and open Brave Shields

Actual result

117180148-ddf39480-ada1-11eb-941a-134279e76c97

Expected result

  • Block text should be Trackers, ads, and more blocked
  • Block text should be left aligned
  • Block count, text, and icons should have a background treatment to give the appearance of justified content

image

Issue reproduces how often

100% reproducible using the above STR.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (sharing button not landed)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+
  • Android version: Android 11

Brave version

  • 1.26.7 Chromium: 90.0.4430.93 - Reproduced

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @anthonypkeane @bsclifton @karenkliu @alexsafe

@kjozwiak kjozwiak added bug feature/shields The overall Shields feature in Brave. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels May 5, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants