Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift Brave Talk to Beta/Release #17210

Closed
bsclifton opened this issue Jul 27, 2021 · 4 comments · Fixed by brave/brave-core#9605
Closed

Uplift Brave Talk to Beta/Release #17210

bsclifton opened this issue Jul 27, 2021 · 4 comments · Fixed by brave/brave-core#9605
Assignees
Labels

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 27, 2021

Test plan

  1. Ensure Brave Talk is enabled in Griffin
  2. Fresh profile
  3. Launch Brave
  4. Open a new tab
  5. You should see the Brave Talk promo (bottom right)
  6. If you click Edit Cards you should be able to add Brave Talk

Description

Currently, Brave Talk is only on Nightly. We need to show it for all channels:

  • Brave Talk widget
  • Icon in bottom right of NTP
  • Tooltip that shows
  • other places?
@bsclifton bsclifton self-assigned this Jul 27, 2021
@bsclifton bsclifton added feature/new-tab premium All issues related to Brave Premium labels Jul 27, 2021
@stephendonner
Copy link

Description

Currently, Brave Talk is only on Nightly. We need to show it for all channels:

  • Brave Talk widget
  • Icon in bottom right of NTP
  • Tooltip that shows
  • other places?

It's in Sidebar, but don't think Sidebar itself is ready (and there shouldn't be anything to do anyhow?)

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Jul 29, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Aug 2, 2021
Will allow us to roll the feature out on other channels using Griffin

Fixes brave/brave-browser#17210
bsclifton added a commit to brave/brave-core that referenced this issue Aug 3, 2021
Will allow us to roll the feature out on other channels using Griffin

Fixes brave/brave-browser#17210
@bsclifton bsclifton added this to the 1.29.x - Nightly milestone Aug 3, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Adding QA/Blocked until we get Brave Talk enabled on main (staging) via Griffin. After it's enabled on staging, QA will be able to run through the above verification. Once we get closer to Brave Talk release date, we'll push the same change into production.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Removing QA/Blocked as brave/brave-variations#93 was merged into main (Griffin staging).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Verification passed on


Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

  • ensured that Brave Talk widget is enabled via NTP on main (staging) after launching brave via the following:
    brave.exe --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveTalkStudy is enabled via brave://version/?show-variations-cmd
    image
  • ensured that the BraveTalk promo tooltip is shown in NTP when the OS clock is forwarded to 3 days
now after 3 days
image image
  • Confirmed Brave Talk can be added to NTP widgets via Edit Cards
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants