Brave Talk code cleanup (renaming) and putting behind flag for Griffin #9605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
changed the title
bsclifton
force-pushed
the
bsc-uplift-brave-talk
branch
from
a6e7c98 to
ee5db1c
Compare
- JavaScript/TypeScript files together => braveTalk - Rename extension API - Rename components/brave_together => components/brave_talk - Rename file `togetherIcon` => `braveTalkIcon` - Rename file `brave-together-icon.tsx` => `brave-talk-svg.tsx`
We can instead put this behind a brave://flags entry
bsclifton
force-pushed
the
bsc-uplift-brave-talk
branch
from
ee5db1c to
b2f2633
Compare
simonhong
reviewed
Aug 2, 2021
goodov
reviewed
Aug 2, 2021
|
Found brave/brave-browser#17301 when testing - this is also happening on Nightly (ex: wasn't introduced by this PR) |
petemill
approved these changes
Aug 2, 2021
Comment on lines
+80
to
+81
| braveTalkPromptDismissed: boolean | ||
| braveTalkSupported: boolean |
There was a problem hiding this comment.
This will bring the prompt back for users on Nightly channel who dismissed it, but that's totally ok by me!
|
Rebase and squashing would be perfect! Maybe once @goodov gives this a re-review, I'll be able to squash it up 😄 |
24 tasks
goodov
reviewed
Aug 3, 2021
goodov
approved these changes
Aug 3, 2021
Originally done as separate commits (one at a time) and compiled/tested after each. Fixes brave/brave-browser#17138 - Update component namespace (from `brave_together` to `brave_talk`) - Update extension API (from `braveTogether` to `braveTalk`) - Update strings (from `together`/`TOGETHER` to `braveTalk`/`BRAVE_TALK`) - Rename `showTogether` => `showBraveTalk` - Rename `togetherSupported` => `braveTalkSupported` - Rename constant `kNewTabPageShowTogether` => `kNewTabPageShowBraveTalk` (Does not affect actual profile setting) - Rename Widget (from `TogetherWidget` to `BraveTalkWidget`) - Rename `togetherPromptDismissed` => `braveTalkPromptDismissed` - Rename `supportsTogether` => `supportsBraveTalk` - Rename `saveShowTogether` => `saveShowBraveTalk` - Rename `toggleShowTogether` => `toggleShowBraveTalk` - Rename `TogetherTooltip` => `BraveTalkTooltip` - Rename `TogetherIcon` => `BraveTalkIcon` - Rename `renderTogetherWidget` => `renderBraveTalkWidget` - Rename `dismissTogetherPrompt` => `dismissBraveTalkPrompt` - Rename `onDismissTogetherPrompt` => `onDismissBraveTalkPrompt` - Rename `togetherBanner` => `braveTalkBanner` - Rename `TogetherItem` => `BraveTalkItem` - Rename `BraveTogetherIcon` as `BraveTalkSvg` - Rename "widget stack" name from `together` to `braveTalk`
Will allow us to roll the feature out on other channels using Griffin Fixes brave/brave-browser#17210
Remove unused code (Brave Talk widget region restriction)
bsclifton
force-pushed
the
bsc-uplift-brave-talk
branch
from
d87ac4c to
d6df0ea
Compare
bsclifton
added a commit
that referenced
this pull request
Aug 3, 2021
Brave Talk code cleanup (renaming) and putting behind flag for Griffin
7 tasks
|
Verified
Steps:
|
|
Also verified on
|
24 tasks
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#17138
Fixes brave/brave-browser#17210
This pull request has two goals:
Brave TogetherorTogetherin the code asBrave TalkWe could then roll this feature out using Griffin on a per-channel basis
Extra care was taken with renaming. I had originally done as a large series of commits and then squashed similar types together (renaming files, updating strings, updating extension API, updating the JavaScript references). Between each commit, I compiled and tested to make sure things work
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: