Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Together => Brave Talk changes - (uplift to 1.28.x) #9608

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 2, 2021

Uplift of #9468
Fixes brave/brave-browser#16799

Uplift of #9581
Fixes brave/brave-browser#17146
Fixes brave/brave-browser#17147

Uplift of #9552
Fixes brave/brave-browser#16798

Uplift of #9605
Fixes brave/brave-browser#17138
Fixes brave/brave-browser#17210

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 2, 2021 07:56
@brave-builds brave-builds self-assigned this Aug 2, 2021
@brave-builds brave-builds added this to the 1.28.x - Beta milestone Aug 2, 2021
@bsclifton bsclifton changed the title Renamed Brave Together to Brave Talk - (Merged into master branch) (uplift to 1.28.x) Renamed Brave Together to Brave Talk - (uplift to 1.28.x) Aug 2, 2021
@bsclifton bsclifton changed the title Renamed Brave Together to Brave Talk - (uplift to 1.28.x) Brave Together => Brave Talk changes - (uplift to 1.28.x) Aug 2, 2021
Rename Brave Together as Brave Talk on NTP (widget)
Brave Talk code cleanup (renaming) and putting behind flag for Griffin
@brave-builds brave-builds requested a review from a team as a code owner August 3, 2021 16:29
@bsclifton bsclifton removed the request for review from a team August 3, 2021 16:30
@kjozwiak
Copy link
Member

kjozwiak commented Aug 3, 2021

With 1.29.47 or higher, Brave Talk will be disabled by default and will need to be enabled via Griffin. QA won't be able to QA/Verify brave/brave-browser#17210 until we push the change to Griffin and enable Brave Talk on Nightly at 100% or users will notice that Brave Talk has been removed.

Once the Griffin change is live, QA will be able to run through brave/brave-browser#17210. CCing @stephendonner

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.28.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#16799 (comment), #9581 (comment), brave/brave-browser#16798 (comment) & #9605 (comment). @stephendonner also checked both main (staging) & production (release).

@kjozwiak kjozwiak merged commit b9537e8 into 1.28.x Aug 4, 2021
@kjozwiak kjozwiak deleted the pr9468_patch-3_1.28.x branch August 4, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants