Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Reset to be under BraveWalletService #11754

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Refactor Reset to be under BraveWalletService #11754

merged 1 commit into from
Jan 6, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 5, 2022

Resolves brave/brave-browser#20346

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from SergeyZhukovsky January 5, 2022 22:00
@bbondy bbondy requested a review from a team as a code owner January 5, 2022 22:00
@bbondy bbondy self-assigned this Jan 5, 2022
@bbondy bbondy mentioned this pull request Jan 5, 2022
Closed
SergeyZhukovsky
SergeyZhukovsky approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy requested a review from a team as a code owner January 6, 2022 13:35
@bbondy bbondy force-pushed the reset-wallet-2 branch 2 times, most recently from c99392d to c3b663e Compare January 6, 2022 15:00
kylehickinson
kylehickinson reviewed Jan 6, 2022
View reviewed changes
ios/browser/brave_wallet/eth_tx_service_factory.h Outdated
@@ -27,6 +27,7 @@ class EthTxServiceFactory : public BrowserStateKeyedServiceFactory {
// Creates the service if it doesn't exist already for |browser_state|.
static mojo::PendingRemote<mojom::EthTxService> GetForBrowserState(
ChromeBrowserState* browser_state);
static KeyringService* GetServiceForState(ChromeBrowserState* browser_state);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be EthTxService

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya... fixed :)
Relying on CI to catch my dumb mistakes for iOS

kylehickinson
kylehickinson approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS looks good :)

@bbondy bbondy merged commit 2bb7659 into master Jan 6, 2022
@bbondy bbondy deleted the reset-wallet-2 branch January 6, 2022 20:17
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 6, 2022
@srirambv srirambv mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.

Move Reset for wallet into BraveWalletService
3 participants
@bbondy @kylehickinson @SergeyZhukovsky