Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Move Reset for wallet into BraveWalletService #4957

Closed
srirambv opened this issue Feb 8, 2022 · 3 comments
Closed

Move Reset for wallet into BraveWalletService #4957

srirambv opened this issue Feb 8, 2022 · 3 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

iOS version of brave/brave-browser#20346

Currently the ResetWallet function is not usable from iOS.
This changes it so you only need to call reset on BraveWalletService.
It also fixes a bug with reloading a tab when not needed for restoring a wallet seed phrase.

@srirambv
Copy link
Contributor Author

srirambv commented Feb 8, 2022

Fixed with brave/brave-core#11754

@srirambv srirambv closed this as completed Feb 8, 2022
@srirambv srirambv added this to the 1.36 milestone Feb 8, 2022
@nuo-xu
Copy link
Contributor

nuo-xu commented Feb 23, 2022

This can be verified through #4777

@srirambv
Copy link
Contributor Author

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.36 (22.2.23.20)

  • Verified steps from issue description
  • Verified reset wallet removes all settings (auto lock, biometric unlock etc)
  • Verified reset wallet deleted the custom network that is added
  • Verified reset wallet hides the wallet option in settings
  • Verified reset works fine on a clean wallet install
  • Verified reset wallet works on restored wallet
  • Verified when reset is done via wallet menu, upon successful reset, brings up the onboarding modal
  • Verified when reset is done via More menu-> Wallet -> Reset or via wallet, setting is hidden until user onboard's again

Verification passed on iPhone XR with iOS 15.3 running 1.36 (22.2.23.20)

  • Verified steps from issue description
  • Verified reset wallet removes all settings (auto lock, face unlock etc)
  • Verified reset wallet deleted the custom network that is added
  • Verified reset wallet hides the wallet option in settings
  • Verified reset works fine on a clean wallet install
  • Verified reset wallet works on restored wallet
  • Verified when reset is done via wallet menu, upon successful reset, brings up the onboarding modal
  • Verified when reset is done via More menu-> Wallet -> Reset or via wallet, setting is hidden until user onboard's again

Verification passed on iPad Pro with iOS 15.4 Beta running 1.36 (22.2.23.20)

  • Verified steps from issue description
  • Verified reset wallet removes all settings (auto lock, bio-metric unlock etc)
  • Verified reset wallet deleted the custom network that is added
  • Verified reset wallet hides the wallet option in settings
  • Verified reset works fine on a clean wallet install
  • Verified reset wallet works on restored wallet
  • Verified when reset is done via wallet menu, upon successful reset, brings up the onboarding modal
  • Verified when reset is done via More menu-> Wallet -> Reset or via wallet, setting is hidden until user onboard's again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants