Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News feed issue when changing orientation after new tab #22439

Closed
Uni-verse opened this issue Apr 20, 2022 · 3 comments · Fixed by brave/brave-core#13951
Closed

News feed issue when changing orientation after new tab #22439

Uni-verse opened this issue Apr 20, 2022 · 3 comments · Fixed by brave/brave-core#13951
Assignees
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 20, 2022

Test plan

See brave/brave-core#13951

Description

When using tablet in the landscape orientation, begin scrolling through news feed, then open NTP and scroll feed again. When changing orientation to portrait, this will cut the feed off at the top and leave gap.

Steps to reproduce

  1. Enable Brave News
  2. Change tablet orientation to landscape
  3. Begin scrolling through news feed
  4. Open new tab
  5. Begin scrolling through feed in the new tab
  6. Change orientation to portrait
  7. Continue scrolling news

Actual result

Leaves a gap at the top of new tab and cuts off feed

news_orientation1.mp4

Expected result

Just like before

Issue reproduces how often

Easily, 100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21, Samsung Galaxy Tab S7
  • Android version: 12

Brave version

1.38.103, Chromium 100.0.4896.127

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality android-tablet-specific feature/brave-news formerly brave-today labels Apr 20, 2022
@Uni-verse Uni-verse added this to the 1.38.x - Release milestone Apr 20, 2022
@Uni-verse Uni-verse changed the title News feed issue when changing orientation [Tablet] News feed issue when changing orientation after new tab [Tablet] Apr 20, 2022
@kjozwiak
Copy link
Member

Removing from the 1.38.x milestone as the above isn't labelled as release/blocking.

@kjozwiak kjozwiak removed this from the 1.38.x - Release milestone Apr 21, 2022
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 27, 2022
@deeppandya
Copy link
Contributor

This bug is also reproducible on phones as well.

@Uni-verse
Copy link
Contributor Author

Verified on Samsung GS 21 & Samsung Galaxy Tab S7 using

Brave	1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit) 
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Android 12; Build/SP1A.210812.016
ExampleExample
22439_fix.mp4
22439_tablet_fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants