Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #21323] Changing tablet orientation will re-render cards in news feed incorrectly [Tablet] #21868

Closed
Uni-verse opened this issue Mar 24, 2022 · 4 comments · Fixed by brave/brave-core#12908

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 24, 2022

Description

Changing tablet orientation will re-render cards in news feed incorrectly. Doesn't happen on mobile.

Follow up for #21323

Steps to reproduce

  1. Clean install 1.37
  2. Enabled News, Show news
  3. Scroll through news feed
  4. Change tablet orientation, scroll back up slightly
  5. Change orientation back again, scroll up and down

Actual result

news_cards01.mp4

Screen Shot 2022-03-24 at 2 53 51 PM

Expected result

Cards should be rendered correctly

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tab S7
  • Android version: Android 11

Brave version

1.37.105 Chromium: 100.0.4896.46 (Official Build) (32-bit) 
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

Above requires 1.38.98 or higher for 1.38.x verification.

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Apr 20, 2022

Verified using 1.38.103, Chromium 100.0.4896.127 on Samsung Galaxy Tab S7 running Android 12

  • Cards are displayed correctly when changing orientation while scrolling through news feed.

Issues encountered - #22439

21868.mp4

@alexsafe
Copy link

alexsafe commented May 25, 2022

Reopening as i see it happening again on latest master. Probably a regression. Now it only happens for the first tab after turning News on.
Screenshot_20220525-042021_Brave - Debug

@kjozwiak
Copy link
Member

Closing as we don't re-open issues that have already been shipped. @alexsafe please create a new issue as this one already has a PR associated with it and has been shipped via 1.38.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants