Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #21868] Changing tablet orientation will re-render cards in news feed incorrectly #23060

Closed
alexsafe opened this issue May 25, 2022 · 1 comment · Fixed by brave/brave-core#13453

Comments

@alexsafe
Copy link

alexsafe commented May 25, 2022

Description

Changing tablet orientation will re-render cards in news feed incorrectly. Happens only on the tab that shows the first news feed after turning news on.

Follow up for #21868

Steps to reproduce

  1. Clean install 1.41
  2. Enabled News, Show news
  3. Scroll through news feed
  4. Change tablet orientation, scroll back up slightly
  5. Change orientation back again, scroll up and down

Check the original issue for details.

If after step 2, we open a new tab things work well. In this situation even coming back to the first tab the rotation changes act as expected.

Actual result

Screenshot_20220525-042021_Brave - Debug

Expected result

The feed should look good on orientation changes at any moment

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Happens on all devices, but more easily visible on Tablet

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Not sure if this has been used in testing but going to App Info->Storage0>Clear storage->Clear all data (or whatever that path is for different devices) resets the app and it's a bit faster than uninstalling then reinstalling.

@Uni-verse
Copy link
Contributor

Verified on Samsung Tab S7 using

Brave 1.41.94 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Android 12; Build/SP1A.210812.016

  • Confirmed that issue above where the news feed is squished while in vertical orientation cannot be repro'd
  • Confirmed user is able to open new tabs and news feed shows immediately
  • Confirmed news feed is displayed properly when user switches between tabs while also changing orientation
  • Confirmed news feed is working on an upgraded profile and could not repro'd the issue above

Encountered - #22439 which will be fixed in 1.43 milestone

23060_fix_01.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants