Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Brave Search Promo - copy / design change #24902

Closed
timchilds opened this issue Aug 23, 2022 · 3 comments · Fixed by brave/brave-core#14778
Closed

[Android] Brave Search Promo - copy / design change #24902

timchilds opened this issue Aug 23, 2022 · 3 comments · Fixed by brave/brave-core#14778
Labels
Brave Search feature/search OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/exclude
Milestone
1.43.x - Release

Comments

@timchilds
Copy link

timchilds commented Aug 23, 2022 •
edited
Loading

The design team have requested a design / copy change to the omnibar brave search promo banner.

Figma: https://www.figma.com/file/8wncTFNBvKN7CS6LTXAMYs?node-id=45:14911#250446537

Image
@anthonypkeane
Copy link

Linked to #23062

@deeppandya deeppandya mentioned this issue Aug 23, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 24, 2022
This was referenced Aug 24, 2022
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Aug 31, 2022 •
edited
Loading

STR/Cases for @brave/qa-team can be found via brave/brave-core#14778 (comment). Example of the screenshots/design can be found via #24902 (comment). Quick Note: the above can be QA'd/verified alongside #23062.

@deeppandya deeppandya mentioned this issue Aug 31, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016
Example Example
Screenshot_20220831-180717_Brave Screenshot_20220831-180736_Brave
Screenshot_20220831-180805_Brave Screenshot_20220831-180750_Brave

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP2A.220305.013
Example Example
Screenshot_20220831_182248_Brave Screenshot_20220831_182310_Brave
Screenshot_20220831_182444_Brave Screenshot_20220831_182339_Brave

@kjozwiak kjozwiak mentioned this issue Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Brave Search feature/search OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Update bg, image resource and text brave/brave-core
5 participants
@kjozwiak @deeppandya @anthonypkeane @timchilds @brave-builds