Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omnibox brave search promo banner android (uplift to 1.43.x) #14542

Merged
merged 3 commits into from
Aug 31, 2022
Merged

omnibox brave search promo banner android (uplift to 1.43.x) #14542

merged 3 commits into from
Aug 31, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 9, 2022 •
edited by kjozwiak
Loading

Uplift of #14350 #14778 #14886
Resolves brave/brave-browser#23062
Resolves brave/brave-browser#24902
Resolves brave/brave-browser#25059

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 9, 2022 04:58
@brave-builds brave-builds self-assigned this Aug 9, 2022
@brave-builds brave-builds added this to the 1.43.x - Beta milestone Aug 9, 2022
@deeppandya deeppandya force-pushed the pr14350_search_engine_default_promo_android_1.43.x branch 4 times, most recently from d9038c9 to 0ed9606 Compare August 30, 2022 18:32
@deeppandya deeppandya force-pushed the pr14350_search_engine_default_promo_android_1.43.x branch from 0ed9606 to 7587531 Compare August 30, 2022 18:57
@kjozwiak kjozwiak mentioned this pull request Aug 30, 2022
Closed
kjozwiak
kjozwiak approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per #14350 (comment), #14778 (comment) & #14886 (comment).

@kjozwiak kjozwiak merged commit 97298de into 1.43.x Aug 31, 2022
@kjozwiak kjozwiak deleted the pr14350_search_engine_default_promo_android_1.43.x branch August 31, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @brave-browser-releases @samartnik @deeppandya