Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave Talk Links #9581

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Update Brave Talk Links #9581

merged 3 commits into from
Jul 29, 2021

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 28, 2021

Fixes brave/brave-browser#17146
Fixes brave/brave-browser#17147

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton marked this pull request as ready for review July 28, 2021 18:36
@bsclifton bsclifton changed the title WIP - Update Brave Talk Links Update Brave Talk Links Jul 28, 2021
@bsclifton
Copy link
Member Author

bsclifton commented Jul 28, 2021

Ready for review 😄
cc: @stephendonner @simonhong

Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please and thanks!

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@bsclifton bsclifton merged commit 90d6dce into master Jul 29, 2021
@bsclifton bsclifton deleted the bsc-update-talk-links branch July 29, 2021 03:59
@bsclifton bsclifton added this to the 1.29.x - Nightly milestone Jul 29, 2021
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.29.38 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)

For brave/brave-browser#17147:

Steps:

  1. new profile
  2. launched Brave
  3. opened a new-tab page
  4. on the bottom right, clicked on the Try it out button

Confirmed the link is now to https://talk.brave.com/widget

Screen Shot 2021-07-29 at 9 10 05 AM

For brave/brave-browser#17146

Steps:

  1. new profile
  2. launch Brave
  3. load a new-tab page
  4. click on Edit cards
  5. add the Brave Together (to be renamed to Brave Talk) card
  6. open the Network panel in Developer Tools
  7. click on the Start video call button
  8. look at the URLs/redirects

Confirmed the URL is now https://talk.brave.com/widget

Screen Shot 2021-07-29 at 9 18 24 AM

bsclifton added a commit that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants