Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Change to new way to Reset Wallet for brave-core 1.36.x upgrade #4777

Closed
bbondy opened this issue Dec 28, 2021 · 6 comments · Fixed by #4931
Closed

Change to new way to Reset Wallet for brave-core 1.36.x upgrade #4777

bbondy opened this issue Dec 28, 2021 · 6 comments · Fixed by #4931

Comments

@bbondy
Copy link
Member

bbondy commented Dec 28, 2021

Description:

Before 1.35.x brave-core, you could just call KeyringController::Reset to reset the wallet. This changes as of this PR:
https://github.com/brave/brave-core/pull/11669/files#diff-d5d80c8bf10054827601d890b9e85e6c9bfc4304b17089bd7d443c94c554f232R19

Resetting Wallet must change to this new method for upgrade to 1.36.x brave-core or else there will be Reset regressions.

cc @nuo-xu or @kylehickinson

@bbondy
Copy link
Member Author

bbondy commented Jan 5, 2022

Update: BraveWalletService::Reset will need to be called only, and that can be done from mojo:
brave/brave-core#11754

@kylehickinson kylehickinson added this to the 1.35 milestone Jan 6, 2022
@bbondy bbondy changed the title Change to new way to Reset Wallet for brave-core 1.35.x upgrade Change to new way to Reset Wallet for brave-core 1.36.x upgrade Jan 6, 2022
@bbondy bbondy modified the milestones: 1.35, 1.36 Jan 6, 2022
@bbondy
Copy link
Member Author

bbondy commented Jan 6, 2022

Moved this to 1.36.x since I'm going to leave the new changes in 1.36.x and revert the 1.35.x changes so there's no upgrade needed for it.

@nuo-xu
Copy link
Contributor

nuo-xu commented Feb 3, 2022

For QAs,
Please do a sanity test on wallet resetting to make sure resetting is not broken.
Thanks

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 4, 2022

Verification in completed using 1.36 (22.2.17.10)

PASSED on iPhone 12 Pro running iOS 15.1.1
PASSED on iPhone X running iOS 14.4.2
PASSED on iPad (7th Gen) running iPadOS 15.2.1

Scenarios:

  • Able to reset brave wallet after upgrading app
  • Able to reset created brave wallet
  • Able to reset restored brave wallet
  • Able to reset restored third party wallet (meta mask)
  • User is taken to the Brave Wallet landing screen upon resetting
  • User is able to reset wallet via the account tab settings > reset
  • User is able to reset wallet via the 3 dot menu > settings > reset

@Uni-verse
Copy link
Contributor

Retested and updated post with new version 1.36 (22.2.17.10) when finding relaunching app after resetting wallet still showed active wallet.

@nuo-xu

@Uni-verse
Copy link
Contributor

Retested and updated post with new version 1.36 (22.2.17.10) when finding relaunching app after resetting wallet still showed active wallet.

@nuo-xu

Just to clarify, I re-tested this scenario and was not able to repro on the build version above so its a PASS. This concludes the verification.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.