-
Notifications
You must be signed in to change notification settings - Fork 447
Change to new way to Reset Wallet for brave-core 1.36.x upgrade #4777
Comments
Update: BraveWalletService::Reset will need to be called only, and that can be done from mojo: |
Moved this to 1.36.x since I'm going to leave the new changes in 1.36.x and revert the 1.35.x changes so there's no upgrade needed for it. |
For QAs, |
Verification in completed using PASSED on Scenarios:
|
Retested and updated post with new version |
Just to clarify, I re-tested this scenario and was not able to repro on the build version above so its a PASS. This concludes the verification. |
Description:
Before 1.35.x brave-core, you could just call KeyringController::Reset to reset the wallet. This changes as of this PR:
https://github.com/brave/brave-core/pull/11669/files#diff-d5d80c8bf10054827601d890b9e85e6c9bfc4304b17089bd7d443c94c554f232R19
Resetting Wallet must change to this new method for upgrade to 1.36.x brave-core or else there will be Reset regressions.
cc @nuo-xu or @kylehickinson
The text was updated successfully, but these errors were encountered: