Summertime #24
Merged
Summertime #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove all explicit reference of node_modules * add `src` option to broccoli build trees * fix usage of doc and win for node, fix import paths * fix issue with exported window, remove js-test * change imports to not use node_modules or descendent paths
Use broccoli, add tests in ci
…to tests fix brocfile and tests to work with new dist structure
Use broccoli multi-builder 0.2.2
use broccoli-test-builder
update demo, add compat layer for win/doc, compile LESS
This reverts commit 658321c.
Event listeners
Image section
* Tests for typing "\r\n" to create section, deleting sections * Refactor selectText to take optional start/end, more deletion tests * add helper `skipInPhantom` * test that when highlighting bold text, the bold button is active * Do not turn stickyToolbar on by default (this breaks Phantom tests) * remove extra `setTimeout` in mouseup listener
Editor section tests
* Cleanup editor (-> class), remove unused utils * classify Toolbar, TextFormatToolbar
editor 'selection', 'selectionUpdated', and 'selectionEnded' events
Also unify the types for posts and markup sections
Post, Section, Markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major PR that heavily refactors the internals of Content-Kit as well as the build tooling and demo.
Much of the main priorities for #13 are completed with this merge.