Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrows disappear on adding color #1342

Closed
tasso94 opened this issue Apr 10, 2019 · 8 comments · Fixed by #1359
Closed

Arrows disappear on adding color #1342

tasso94 opened this issue Apr 10, 2019 · 8 comments · Fixed by #1359
Assignees
@nikku
Labels
bug Something isn't working channel:support
Milestone
M29

Comments

@tasso94
Copy link
Member

tasso94 commented Apr 10, 2019 •
edited by nikku
Loading

Steps to reproduce

  1. Open Camunda Model 3.0.1
  2. Create a BPMN model with a Sequence Flow
  3. Select the Sequence Flow
  4. Set an element color to the Sequence Flow

Expected behavior
The Sequence Flow arrow is colored.

Observed behavior
Th arrow of the Sequence Flow disappears:

image

Depends on bpmn-io/bpmn-js#972

Related to SUPPORT-5950
@tasso94 tasso94 added the bug Something isn't working label Apr 10, 2019
@nikku
Copy link
Member

nikku commented Apr 10, 2019 •
edited
Loading

Thanks for reporting this bug. As it looks like, this is an issue with Camunda Modeler v2.x, too.

@nikku
Copy link
Member

nikku commented Apr 10, 2019 •
edited
Loading

Problem persists across imports, cf. example diagram.

nikku added a commit to bpmn-io/bpmn-js that referenced this issue Apr 10, 2019
@nikku
fix(draw): render hex and rgb encoded color markers
76922bc 
Until now we did not properly sanitize the IDs we create for colored
markers.

This would make the marker retrival fail with fill and stroke colors
encoded in hex and rgb(a, b, c) form.

This improves the situation by removing forbidden chars from the marker
ID.

Related to camunda/camunda-modeler#1342
@nikku nikku mentioned this issue Apr 10, 2019
Merged
nikku added a commit to bpmn-io/bpmn-js that referenced this issue Apr 10, 2019
@nikku
fix(draw): render hex and rgb encoded color markers
e7b1e53 
Until now we did not properly sanitize the IDs we create for colored
markers. This would make the marker retrival fail with fill and
stroke colors encoded in hex and rgb(a, b, c) form.

This commit improves the situation by removing forbidden chars from
the marker ID.

Related to camunda/camunda-modeler#1342
@nikku
Copy link
Member

nikku commented Apr 11, 2019

The issue is / was that we do / did not properly account for hex (#aabbcc) and rgb encoded colors in our BPMN toolkit. This gets fixed via bpmn-io/bpmn-js#972.

@nikku nikku added this to the M29 milestone Apr 11, 2019
@nikku nikku added the needs review Review pending label Apr 11, 2019
nikku added a commit to bpmn-io/bpmn-js that referenced this issue Apr 16, 2019
@nikku
fix(draw): render hex and rgb encoded color markers
aaff6d9 
Until now we did not properly sanitize the IDs we create for colored
markers. This would make the marker retrival fail with fill and
stroke colors encoded in hex and rgb(a, b, c) form.

This commit improves the situation by removing forbidden chars from
the marker ID.

Closes #981
Related to camunda/camunda-modeler#1342
philippfromme pushed a commit to bpmn-io/bpmn-js that referenced this issue Apr 18, 2019
@nikku @philippfromme
fix(draw): render hex and rgb encoded color markers
969cbf8 
Until now we did not properly sanitize the IDs we create for colored
markers. This would make the marker retrival fail with fill and
stroke colors encoded in hex and rgb(a, b, c) form.

This commit improves the situation by removing forbidden chars from
the marker ID.

Closes #981
Related to camunda/camunda-modeler#1342
merge-me bot pushed a commit to bpmn-io/bpmn-js that referenced this issue Apr 18, 2019
@nikku @merge-me
fix(draw): render hex and rgb encoded color markers
13e3752 
Until now we did not properly sanitize the IDs we create for colored
markers. This would make the marker retrival fail with fill and
stroke colors encoded in hex and rgb(a, b, c) form.

This commit improves the situation by removing forbidden chars from
the marker ID.

Closes #981
Related to camunda/camunda-modeler#1342
nikku added a commit that referenced this issue Apr 26, 2019
@nikku
chore(client): bump to [email protected] / [email protected]
5fbd1f5 
Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342
@nikku nikku mentioned this issue Apr 26, 2019
Merged
@ghost ghost assigned nikku Apr 26, 2019
nikku added a commit that referenced this issue Apr 26, 2019
@nikku
chore(client): bump to [email protected] / [email protected]
6aff71c 
Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342
@slizenko
Copy link

slizenko commented May 8, 2019

I have the same problem in Modeler 3.1 for Windows x64 -
when transition colored, direction arrow disappeared.

merge-me bot pushed a commit that referenced this issue May 8, 2019
@nikku @merge-me
chore(client): bump to [email protected] / [email protected]
aafbda4 
Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342
@pinussilvestrus
Copy link
Contributor

Closed via aafbda4

@ghost ghost removed the needs review Review pending label May 9, 2019
@tasso94 tasso94 mentioned this issue May 20, 2019
Closed
philippfromme pushed a commit that referenced this issue Jun 6, 2019
@nikku @philippfromme
chore(client): bump to [email protected] / [email protected]
177a038 
Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342
philippfromme pushed a commit that referenced this issue Jun 6, 2019
@nikku @philippfromme
chore(client): bump to [email protected] / [email protected]
eb95b0b 
Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342
@nikku nikku mentioned this issue Jun 12, 2019
Closed
@sebwarnke
Copy link

This problem is still there in Modeler 3.1.2

@nikku
Copy link
Member

nikku commented Jun 19, 2019

Correct. It is gone in the nightly though.

@kurtudis
Copy link

relates to SUPPORT-5950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working channel:support
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

chore(client): bump to [email protected] / [email protected] camunda/camunda-modeler
6 participants
@nikku @tasso94 @pinussilvestrus @sebwarnke @kurtudis @slizenko