Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): bump to [email protected] / [email protected] #1359

Merged
merged 4 commits into from
May 8, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Apr 26, 2019

The PR to close all issues 🎺.

Closes #672
Closes #1052
Closes #1204
Closes #1209
Closes #1210
Closes #1342

@ghost ghost assigned nikku Apr 26, 2019
@ghost ghost added the needs review Review pending label Apr 26, 2019
@nikku
Copy link
Member Author

nikku commented Apr 26, 2019

This is not ready to merge yet. In fact, after the diagram-js update the CMMN Editor blows up:

bug

The following stack trace is emitted:

[diagram_1.cmmn] Cannot read property 'layoutConnection' of undefined
    at layoutConnection (webpack:///node_modules/diagram-js/lib/features/modeling/cmd/ReconnectConnectionHandler.js:62:0)
    at postExecute (webpack:///node_modules/diagram-js/lib/command/CommandStack.js:417:0)
    at _internalExecute (webpack:///node_modules/diagram-js/lib/command/CommandStack.js:147:0)
    at execute (webpack:///node_modules/cmmn-js/lib/features/modeling/Modeling.js:118:0)
    at file:///xxx/camunda-modeler/dist/linux-unpacked/resources/app.asar/public/1.1.js:1:91851
    at file:///xxx/camunda-modeler/dist/linux-unpacked/resources/app.asar/public/1.1.js:1:17938
    at listener (webpack:///node_modules/diagram-js/lib/core/EventBus.js:362:0)
    at _invokeListener (webpack:///node_modules/diagram-js/lib/core/EventBus.js:348:0)
    at _invokeListeners (webpack:///node_modules/diagram-js/lib/core/EventBus.js:310:0)
    at fire (webpack:///node_modules/diagram-js/lib/features/dragging/Dragging.js:170:0) [ error ]

@nikku
Copy link
Member Author

nikku commented Apr 26, 2019

Fixed described cmmn-js bug in [email protected].

@nikku nikku marked this pull request as ready for review April 26, 2019 15:13
@nikku nikku requested a review from philippfromme April 26, 2019 15:13
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@merge-me merge-me bot merged commit bb4accd into master May 8, 2019
@ghost ghost removed the needs review Review pending label May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the bump-bpmn-js branch May 8, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment