Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow reuse of icmp/ping code in vizroute #147

Merged
merged 18 commits into from
Aug 24, 2024

refactor

eebf743
Select commit
Loading
Failed to load commit list.
Merged

refactor: allow reuse of icmp/ping code in vizroute #147

refactor
eebf743
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 24, 2024 in 0s

88.79% of diff hit (target 76.87%)

View this Pull Request on Codecov

88.79% of diff hit (target 76.87%)

Annotations

Check warning on line 38 in internal/cmd/pinger.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/cmd/pinger.go#L38 

Added line #L38 was not covered by tests

Check warning on line 91 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L90-L91 

Added lines #L90 - L91 were not covered by tests

Check warning on line 102 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L102 

Added line #L102 was not covered by tests

Check warning on line 108 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L108 

Added line #L108 was not covered by tests

Check warning on line 112 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L112 

Added line #L112 was not covered by tests

Check warning on line 133 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L133 

Added line #L133 was not covered by tests

Check warning on line 139 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L139 

Added line #L139 was not covered by tests

Check warning on line 157 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L156-L157 

Added lines #L156 - L157 were not covered by tests

Check warning on line 166 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L166 

Added line #L166 was not covered by tests

Check warning on line 178 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L178 

Added line #L178 was not covered by tests

Check warning on line 194 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L194 

Added line #L194 was not covered by tests

Check warning on line 221 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L220-L221 

Added lines #L220 - L221 were not covered by tests

Check warning on line 249 in pkg/ping/icmp/icmp.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/icmp/icmp.go#L249 

Added line #L249 was not covered by tests

Check warning on line 56 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L56 

Added line #L56 was not covered by tests

Check warning on line 62 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L62 

Added line #L62 was not covered by tests

Check warning on line 66 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L64-L66 

Added lines #L64 - L66 were not covered by tests

Check warning on line 68 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L68 

Added line #L68 was not covered by tests

Check warning on line 91 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L90-L91 

Added lines #L90 - L91 were not covered by tests

Check warning on line 94 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L93-L94 

Added lines #L93 - L94 were not covered by tests

Check warning on line 100 in pkg/ping/ping.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/ping/ping.go#L99-L100 

Added lines #L99 - L100 were not covered by tests
View more details on Codecov