Fixing initialization of event setup point of PR 6030

[mmusich]

Small fix to save memory. Initializing event setup pointer once for all

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_3_X.

Fixing initialization of event setup point of PR 6030

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

The framework does not guarantee that we will always keep the same EventSetup object throughout the job. Please close this commit.

[mmusich]

I am not sure to understand the comment. We just need the EventSetup pointer once in the endjob to invoke the TrackerTopology. Before this commit tlampen@078138b, lastSetup_ was simply a nullptr, which was causing seg faults.

[Dr15Jones]

You can't use the EventSetup in the endJob, nor can you use any data held by the EventSetup. That is why it is not passed as a value to the various module's endJob. Please find another way to accomplish what you are trying to do.

[mmusich]

Thanks for the clarification. Does this imply we should revert also commit 078138b from @tlampen in PR #6030 (which, by the way has already been merged) and in all the backport PR #6070 #6072 and #6073?

[Dr15Jones]

hold

[cmsbuild]

+1
Tested at: b9e1929
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6085/496/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6085/496/summary.html

[mmusich]

As agreed with @diguida and @rcastello, while I'll try to figure out a better implementation. I reverted the unsafe commits. Please notice that these also reverts 078138b from @tlampen.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6085/642/summary.html

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.